Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031203002: [Clean-up] Remove NetworkStats code, which has been dead code since July 2014. (Closed)

Created:
5 years, 9 months ago by Ilya Sherman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Clean-up] Remove NetworkStats code, which has been dead code since July 2014. BUG=470630 TEST=none R=rtenneti@chromium.org Committed: https://crrev.com/fc021e9192f830c47d7e777e42ad561dd6457b54 Cr-Commit-Position: refs/heads/master@{#322261}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1841 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 2 chunks +5 lines, -2 lines 0 comments Download
D chrome/browser/metrics/network_stats_uploader.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/metrics/network_stats_uploader.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/net/network_stats.h View 1 chunk +0 lines, -390 lines 0 comments Download
D chrome/browser/net/network_stats.cc View 1 chunk +0 lines, -962 lines 0 comments Download
D chrome/browser/net/network_stats_unittest.cc View 1 chunk +0 lines, -410 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Ilya Sherman
5 years, 9 months ago (2015-03-25 18:57:28 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/1031203002/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc File chrome/browser/metrics/chrome_metrics_service_client.cc (right): https://codereview.chromium.org/1031203002/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc#newcode39 chrome/browser/metrics/chrome_metrics_service_client.cc:39: #include "components/metrics/net/net_metrics_log_uploader.h" We could delete #include "components/metrics/net/net_metrics_log_uploader.h"
5 years, 9 months ago (2015-03-25 19:24:27 UTC) #2
Ilya Sherman
https://codereview.chromium.org/1031203002/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc File chrome/browser/metrics/chrome_metrics_service_client.cc (right): https://codereview.chromium.org/1031203002/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc#newcode39 chrome/browser/metrics/chrome_metrics_service_client.cc:39: #include "components/metrics/net/net_metrics_log_uploader.h" On 2015/03/25 19:24:27, ramant wrote: > We ...
5 years, 9 months ago (2015-03-25 21:12:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031203002/20001
5 years, 9 months ago (2015-03-25 21:12:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 23:33:41 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 23:34:49 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fc021e9192f830c47d7e777e42ad561dd6457b54
Cr-Commit-Position: refs/heads/master@{#322261}

Powered by Google App Engine
This is Rietveld 408576698