Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index c781413d863bc6648243a4b88bec7cd240d03158..fce9293115650f6a4ea58b13941686bda1d07bf9 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -50,7 +50,13 @@ class PasswordManagerClient {
// If the password manager should work for the current page. Default
// always returns true.
- virtual bool IsPasswordManagerEnabledForCurrentPage() const;
+ virtual bool IsPasswordManagementEnabledForCurrentPage() const;
+
+ // Is saving new data for password autofill enabled for the current profile
+ // and page? For example, saving new data is disabled in Incognito mode,
+ // whereas filling data is not. Also, saving data is disabled in the presence
+ // of SSL errors on a page.
+ virtual bool IsSavingEnabledForCurrentPage() const;
// Return true if |form| should not be available for autofill.
virtual bool ShouldFilterAutofillResult(

Powered by Google App Engine
This is Rietveld 408576698