components/password_manager/core/browser/password_manager.h - Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/content/browser/credential_manager_dispatcher.cc ('K') | « components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.h

diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h

index e4da485bd66e2030ac5a9c19d8979c9b213cab5f..2c65e6b651be6e837a62b95a0b324a874c85e83f 100644

--- a/components/password_manager/core/browser/password_manager.h

+++ b/components/password_manager/core/browser/password_manager.h

@@ -124,11 +124,6 @@ class PasswordManager : public LoginModel {

MAX_FAILURE_VALUE

};

- // Returns if the password manager is enabled for this page. There are certain

- // situations (e.g. bad SSL cert) where we disable the password manager

- // temporarily.

- bool IsEnabledForCurrentPage() const;

// Log failure for UMA. Logs additional metrics if the |form_origin|

// corresponds to one of the top, explicitly monitored websites. For some

// values of |failure| also sends logs to the internals page through |logger|,