components/password_manager/core/browser/password_manager_client.cc - Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.cc

diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc

index b7a3d8e96e118cbb8a6ab7c0769111353e52c43c..db9716716e169fed6f74fb27951144b181ab2631 100644

--- a/components/password_manager/core/browser/password_manager_client.cc

+++ b/components/password_manager/core/browser/password_manager_client.cc

@@ -10,6 +10,10 @@ bool PasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {

return false;

}

+bool PasswordManagerClient::IsEnabledForCurrentPage() const {

+ return true;

bool PasswordManagerClient::IsPasswordManagerEnabledForCurrentPage() const {

return true;

}