components/password_manager/content/browser/credential_manager_dispatcher.cc - Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher.cc

Issue 1031153002: [Credential Management] Smart lock save Credentials bubble should not always pop up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('K') | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | components/password_manager/core/browser/password_manager.h » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_dispatcher.cc

diff --git a/components/password_manager/content/browser/credential_manager_dispatcher.cc b/components/password_manager/content/browser/credential_manager_dispatcher.cc

index 6a2b3a5662f23d0ae003115dcff193fe37211209..1716db7e3bb6245c6df33d78610b25d2f58b21ec 100644

--- a/components/password_manager/content/browser/credential_manager_dispatcher.cc

+++ b/components/password_manager/content/browser/credential_manager_dispatcher.cc

@@ -236,8 +236,10 @@ void CredentialManagerDispatcher::OnNotifySignedIn(

void CredentialManagerDispatcher::OnProvisionalSaveComplete() {

DCHECK(form_manager_);

- client_->PromptUserToSavePassword(

- form_manager_.Pass(), CredentialSourceType::CREDENTIAL_SOURCE_API);

+ if (client_->IsEnabledForCurrentPage() && !form_manager_->IsBlacklisted()) {

+ client_->PromptUserToSavePassword(

+ form_manager_.Pass(), CredentialSourceType::CREDENTIAL_SOURCE_API);

+ }

}

void CredentialManagerDispatcher::OnNotifySignedOut(int request_id) {