[Credential Management] Smart lock save Credentials bubble should not always pop up.

components/password_manager/content/browser/credential_manager_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/credential_manager_dispatcher.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_vector.h"
+#include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/content/browser/content_password_manager_driver.h"
 #include "components/password_manager/content/browser/content_password_manager_driver_factory.h"
 #include "components/password_manager/content/browser/credential_manager_password_form_manager.h"
 #include "components/password_manager/content/common/credential_manager_messages.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/common/credential_manager_types.h"
@@ skipping 210 matching lines @@
 
   // TODO(mkwst): This is a stub; we should be checking the PasswordStore to
   // determine whether or not the credential exists, and calling UpdateLogin
   // accordingly.
   form_manager_.reset(new CredentialManagerPasswordFormManager(
       client_, GetDriver(), *form, this));
 }
 
 void CredentialManagerDispatcher::OnProvisionalSaveComplete() {
   DCHECK(form_manager_);
-  client_->PromptUserToSavePassword(
-      form_manager_.Pass(), CredentialSourceType::CREDENTIAL_SOURCE_API);
+  if (IsSavingEnabledForCurrentPage() && !form_manager_->IsBlacklisted()) {
+    client_->PromptUserToSavePassword(
+        form_manager_.Pass(), CredentialSourceType::CREDENTIAL_SOURCE_API);
+  }
 }
 
 void CredentialManagerDispatcher::OnNotifySignedOut(int request_id) {
   DCHECK(request_id);
 
   PasswordStore* store = GetPasswordStore();
   if (store) {
     if (!pending_sign_out_) {
       pending_sign_out_.reset(new PendingSignedOutTask(
           this, web_contents()->GetLastCommittedURL().GetOrigin()));
@@ skipping 43 matching lines @@
 
   // This will result in a callback to
   // PendingRequestTask::OnGetPasswordStoreResults().
   store->GetAutofillableLogins(pending_request_.get());
 }
 
 PasswordStore* CredentialManagerDispatcher::GetPasswordStore() {
   return client_ ? client_->GetPasswordStore() : nullptr;
 }
 
 bool CredentialManagerDispatcher::IsSavingEnabledForCurrentPage() const {

[vabr (Chromium), 2015/03/30 10:58:42]

Currently, this duplicates PasswordManager::IsSavingEnabledForCurrentPage. I
believe it makes sense to move this method up to the client as well, and call it
on the client from both PasswordManager and CredentialManagerDispatcher. What do
you think?

[melandory, 2015/04/07 13:14:13]

Done.

-  // TODO(vasilii): add more, see http://crbug.com/450583.
-  return !client_->IsOffTheRecord();
+  bool is_saving_enabled = client_->GetPrefs()->GetBoolean(
+      password_manager::prefs::kPasswordManagerSavingEnabled);
+  return is_saving_enabled && !client_->IsOffTheRecord() &&
+         !client_->DidLastPageLoadEncounterSSLErrors() &&
+         client_->IsPasswordManagerEnabledForCurrentPage();
 }
 
 bool CredentialManagerDispatcher::IsZeroClickAllowed() const {
   return *auto_signin_enabled_ && !client_->IsOffTheRecord();
 }
 
 base::WeakPtr<PasswordManagerDriver> CredentialManagerDispatcher::GetDriver() {
   ContentPasswordManagerDriverFactory* driver_factory =
       ContentPasswordManagerDriverFactory::FromWebContents(web_contents());
   DCHECK(driver_factory);
@@ skipping 24 matching lines @@
           pending_request_->id(), info));
   pending_request_.reset();
 }
 
 void CredentialManagerDispatcher::DoneSigningOut() {
   DCHECK(pending_sign_out_);
   pending_sign_out_.reset();
 }
 
 }  // namespace password_manager