[Credential Management] Smart lock save Credentials bubble should not always pop up.

chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/command_line.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
@@ skipping 32 matching lines @@
   explicit TestChromePasswordManagerClient(content::WebContents* web_contents)
       : ChromePasswordManagerClient(web_contents, nullptr),
         is_sync_account_credential_(false) {}
   ~TestChromePasswordManagerClient() override {}
 
   bool IsSyncAccountCredential(const std::string& username,
                                const std::string& origin) const override {
     return is_sync_account_credential_;
   }
 
+  bool DidLastPageLoadEncounterSSLErrors() const override {
+    return ssl_errors_;
+  }
+
+  bool IsPasswordManagerEnabledForCurrentPage() const override {
+    return is_password_manager_enabled_for_current_page_;
+  }
+
   void set_is_sync_account_credential(bool is_sync_account_credential) {
     is_sync_account_credential_ = is_sync_account_credential;
   }
 
+  void set_ssl_errors(bool ssl_errors) { ssl_errors_ = ssl_errors; }
+
+  void set_is_password_manager_enabled_for_current_page(
+      bool is_password_manager_enabled_for_current_page) {
+    is_password_manager_enabled_for_current_page_ =
+        is_password_manager_enabled_for_current_page;
+  }
+
  private:
   bool is_sync_account_credential_;
+  bool is_password_manager_enabled_for_current_page_;
+  bool ssl_errors_;
 
   DISALLOW_COPY_AND_ASSIGN(TestChromePasswordManagerClient);
 };
 
 }  // namespace
 
 class ChromePasswordManagerClientTest : public ChromeRenderViewHostTestHarness {
  public:
   ChromePasswordManagerClientTest();
 
@@ skipping 198 matching lines @@
   // Adding disallow switch should cause sync credential to be filtered.
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   command_line->AppendSwitch(
       password_manager::switches::kDisallowAutofillSyncCredential);
   client.reset(new TestChromePasswordManagerClient(web_contents()));
   client->set_is_sync_account_credential(true);
   NavigateAndCommit(GURL("https://accounts.google.com/Login"));
   EXPECT_TRUE(client->ShouldFilterAutofillResult(form));
 }
 
+TEST_F(ChromePasswordManagerClientTest, IsEnabledForCurrentPage) {

[vabr (Chromium), 2015/03/26 14:51:59]

If you get rid of IsEnabledForCurrentPage, then of course feel free to delete
this test (i.e., there is no need to replace it by testing the components of
IsEnabledForCurrentPage).

[melandory, 2015/03/30 09:50:17]

Done.

+  scoped_ptr<TestChromePasswordManagerClient> client(
+      new TestChromePasswordManagerClient(web_contents()));
+  client->set_ssl_errors(true);
+  client->set_is_password_manager_enabled_for_current_page(true);
+  EXPECT_FALSE(client->IsEnabledForCurrentPage());
+
+  client->set_ssl_errors(true);
+  client->set_is_password_manager_enabled_for_current_page(false);
+  EXPECT_FALSE(client->IsEnabledForCurrentPage());
+
+  client->set_ssl_errors(false);
+  client->set_is_password_manager_enabled_for_current_page(false);
+  EXPECT_FALSE(client->IsEnabledForCurrentPage());
+
+  client->set_ssl_errors(false);
+  client->set_is_password_manager_enabled_for_current_page(true);
+  EXPECT_TRUE(client->IsEnabledForCurrentPage());
+}
+
 TEST_F(ChromePasswordManagerClientTest,
        IsPasswordManagerEnabledForCurrentPage) {
   ChromePasswordManagerClient* client = GetClient();
   NavigateAndCommit(
       GURL("https://accounts.google.com/ServiceLogin?continue="
            "https://passwords.google.com/settings&rart=123"));
   EXPECT_FALSE(client->IsPasswordManagerEnabledForCurrentPage());
 
   // Password site is inaccesible via HTTP, but because of HSTS the following
   // link should still continue to https://passwords.google.com.
@@ skipping 94 matching lines @@
 
   // Again, without a custom passphrase.
   EXPECT_CALL(*mock_sync_service, IsUsingSecondaryPassphrase())
       .WillRepeatedly(Return(false));
 
   EXPECT_FALSE(
       client->IsPasswordSyncEnabled(password_manager::ONLY_CUSTOM_PASSPHRASE));
   EXPECT_FALSE(client->IsPasswordSyncEnabled(
       password_manager::WITHOUT_CUSTOM_PASSPHRASE));
 }