Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 103113002: Mojo: (POSIX) Pass channel handle to child. (Closed)

Created:
7 years ago by viettrungluu
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: (POSIX) Pass channel handle to child. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238487

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -33 lines) Patch
M mojo/common/test/multiprocess_test_base.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/common/test/multiprocess_test_base.cc View 1 7 chunks +20 lines, -9 lines 0 comments Download
M mojo/common/test/multiprocess_test_base_unittest.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/system/platform_channel.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/system/platform_channel_handle.h View 2 chunks +4 lines, -0 lines 0 comments Download
A mojo/system/platform_channel_handle.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M mojo/system/platform_channel_posix.cc View 4 chunks +54 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
7 years ago (2013-12-03 22:27:25 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/103113002/diff/1/mojo/common/test/multiprocess_test_base.h File mojo/common/test/multiprocess_test_base.h (right): https://codereview.chromium.org/103113002/diff/1/mojo/common/test/multiprocess_test_base.h#newcode41 mojo/common/test/multiprocess_test_base.h:41: scoped_ptr<system::PlatformServerChannel>& platform_server_channel() { per style guide, shouldn't this ...
7 years ago (2013-12-03 22:36:01 UTC) #2
viettrungluu
On 2013/12/03 22:36:01, darin wrote: > LGTM > > https://codereview.chromium.org/103113002/diff/1/mojo/common/test/multiprocess_test_base.h > File mojo/common/test/multiprocess_test_base.h (right): > ...
7 years ago (2013-12-03 22:49:45 UTC) #3
viettrungluu
7 years ago (2013-12-03 23:45:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r238487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698