Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: test/cctest/compiler/call-tester.h

Issue 1031113002: Make ParameterTraits specializations for 32-bit integers valid for all arches. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/call-tester.h
diff --git a/test/cctest/compiler/call-tester.h b/test/cctest/compiler/call-tester.h
index 199c23c6cec07b0e24efab9a3452d698e3f184a8..30bbe1e8aa1822e87a1ab5a10f714cc2c5fd7730 100644
--- a/test/cctest/compiler/call-tester.h
+++ b/test/cctest/compiler/call-tester.h
@@ -128,7 +128,6 @@ struct ParameterTraits<T*> {
static uintptr_t Cast(void* r) { return reinterpret_cast<uintptr_t>(r); }
};
-#if V8_TARGET_ARCH_MIPS64
// Additional template specialization required for mips64 to sign-extend
// parameters defined by calling convention.
template <>
@@ -142,7 +141,6 @@ struct ParameterTraits<uint32_t> {
return static_cast<int64_t>(static_cast<int32_t>(r));
}
};
-#endif
class CallHelper {
public:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698