Issue 1031093002: Menu in StocksApp should dismiss when tapping elsewhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1031093002: Menu in StocksApp should dismiss when tapping elsewhere (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, Hixie

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Menu in StocksApp should dismiss when tapping elsewhere When the StocksApp menu is showing, the user shouldn't be able to interact with the rest of the app. Instead, taps outside the menu should dismiss the menu. This CL makes that happen by adding a ModalOverlay on top of the app. We might want to do something fancier in the future using event delegation, but this works for now. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/62ce0fb8c5b7c6e38f31d574edb0774694cb03fe

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -20 lines)			Patch
	M	sky/examples/stocks-fn/lib/stock_app.dart	View		4 chunks	+23 lines, -20 lines	0 comments	Download
	A	sky/framework/components/modal_overlay.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

5 years, 9 months ago (2015-03-25 17:43:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62ce0fb8c5b7c6e38f31d574edb0774694cb03fe (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages