Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1031083003: Add tracing for major GC in Sky (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, ojan
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add tracing for major GC in Sky Ideally we'd trace VM operations from inside the VM, but we don't yet have DartVM wired into tracing. Instead, we use these GC hooks to trace how long major GC takes. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9649e520d4374dab36d9450a5bb7ba37092a7c0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sky/engine/tonic/dart_gc_controller.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-25 17:21:15 UTC) #2
rafaelw
lgtm. nice.
5 years, 9 months ago (2015-03-25 17:32:10 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-25 17:46:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9649e520d4374dab36d9450a5bb7ba37092a7c0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698