Issue 1031083003: Add tracing for major GC in Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1031083003: Add tracing for major GC in Sky (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, ojan

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add tracing for major GC in Sky Ideally we'd trace VM operations from inside the VM, but we don't yet have DartVM wired into tracing. Instead, we use these GC hooks to trace how long major GC takes. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9649e520d4374dab36d9450a5bb7ba37092a7c0d

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	sky/engine/tonic/dart_gc_controller.cc	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 9 months ago (2015-03-25 17:46:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9649e520d4374dab36d9450a5bb7ba37092a7c0d (presubmit successful).