Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031073003: Deprecate Attr child nodes (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Deprecate Attr child nodes Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/tW6Lr5nA1pY/BOedStgP2pEJ Unfortunately this leads to duplicated deprecation warnings if one e.g. sets attr.firstChild.data = 'foo', but both are needed to cover the cases of mere access, like attr.firstChild, and mere modification, like attr.appendChild(). BUG=305105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192530

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -4 lines) Patch
M LayoutTests/dom/html/level1/core/hc_attrappendchild1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild3-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild5-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild6-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrchildnodes1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrchildnodes2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrclonenode1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrfirstchild-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore6-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrlastchild-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrnormalize-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrremovechild1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrreplacechild1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrreplacechild2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrsetvalue1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrsetvalue2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/html/level1/core/hc_elementnormalize2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild3-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild5-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild6-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrchildnodes1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrchildnodes2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrclonenode1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrfirstchild-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore3-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore4-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore6-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrlastchild-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrnormalize-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrremovechild1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrreplacechild1-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrreplacechild2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrsetvalue1-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrsetvalue2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_elementnormalize2-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode01-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode02-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeisequalnode16-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild28-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild29-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/noderemovechild30-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Attr/child-nodes-cache-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Attr/child-nodes-length-cache-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/normalize-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/normalize-crash2-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-attributes-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/attribute-empty-value-no-children-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/import-attribute-node-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/insertedIntoDocument-child-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/insertedIntoDocument-sibling-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/normalize-attributes-mutation-event-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-event-target-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/storage/storage-detached-iframe-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/svg/custom/massive-coordinates-expected.png View 1 2 Binary file 0 comments Download
M LayoutTests/svg/custom/image-with-attr-change-after-delete-crash-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/traversal/moz-bug590771-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
philipj_slow
oops
5 years, 9 months ago (2015-03-25 03:21:05 UTC) #1
philipj_slow
update test expectations
5 years, 9 months ago (2015-03-25 05:50:26 UTC) #2
philipj_slow
PTAL
5 years, 9 months ago (2015-03-25 07:00:19 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-25 12:24:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031073003/40001
5 years, 9 months ago (2015-03-25 12:31:23 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 12:36:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192530

Powered by Google App Engine
This is Rietveld 408576698