precache: Move the java files into //components/precache/android

precache: Move the java files into //components/precache/android

This moves code out of //java/apps/chrome/.../precache into:
  . //components/precache/android/: classes that provide information about
    device-state, network connectivity etc.
  . //chrome/android/.../precache/: precache service and service launchers.

BUG=401552
Committed: https://crrev.com/efb5a13547940947b2c8f42a4e9ed64d45bdd2d2
Cr-Commit-Position: refs/heads/master@{#322298}

[sadrul, 2015-03-24 22:56:24]

sadrul@chromium.org changed reviewers:
+ bengr@chromium.org, yfriedman@chromium.org

[bengr, 2015-03-24 23:11:22]

lgtm

[Yaron, 2015-03-25 15:16:12]

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
(right):

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java:85:
privacyPreferencesManager,
weird indent. please move up to line above (not that java goes for 100 cols, not
80)

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java
(right):

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
We've been updating copyright dates in the moves to upstream.

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java:36:
"org.chromium.components.precache.PrecacheService.START_PRECACHE";
Why is this using the component's precache package but lives in chrome/android?
It seems like this should have the chrome layer package (i.e. matching this
class location)

https://codereview.chromium.org/1031003003/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

https://codereview.chromium.org/1031003003/diff/1/chrome/chrome.gyp#newcode621
chrome/chrome.gyp:621: '../components/components.gyp:precache_java',
You need to replicate this in gn.

[sadrul, 2015-03-25 18:05:25]

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
(right):

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java:85:
privacyPreferencesManager,
On 2015/03/25 15:16:12, Yaron wrote:
> weird indent. please move up to line above (not that java goes for 100 cols,
not
> 80)

I ran 'git cl format' on the while CL and that fixed this and a few other
indents. (unless we don't want to do that during upstreaming to avoid increased
diffcounts, in which case, I will revert the other changes)

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java
(right):

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/03/25 15:16:12, Yaron wrote:
> We've been updating copyright dates in the moves to upstream.

Done.

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java:36:
"org.chromium.components.precache.PrecacheService.START_PRECACHE";
On 2015/03/25 15:16:12, Yaron wrote:
> Why is this using the component's precache package but lives in
chrome/android?
> It seems like this should have the chrome layer package (i.e. matching this
> class location)

Oops, my bad, overzealous search/replace! (I had it fixed locally afterwards,
but looks like I hadn't updated the patch)

https://codereview.chromium.org/1031003003/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

https://codereview.chromium.org/1031003003/diff/1/chrome/chrome.gyp#newcode621
chrome/chrome.gyp:621: '../components/components.gyp:precache_java',
On 2015/03/25 15:16:12, Yaron wrote:
> You need to replicate this in gn.

Done.

https://codereview.chromium.org/1031003003/diff/40001/chrome/android/shell/ja...
File chrome/android/shell/java/AndroidManifest.xml.jinja2 (right):

https://codereview.chromium.org/1031003003/diff/40001/chrome/android/shell/ja...
chrome/android/shell/java/AndroidManifest.xml.jinja2:204: </receiver>
Is this the right manifest file to update?

[Yaron, 2015-03-25 19:06:53]

lgtm

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
(right):

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java:85:
privacyPreferencesManager,
On 2015/03/25 18:05:24, sadrul wrote:
> On 2015/03/25 15:16:12, Yaron wrote:
> > weird indent. please move up to line above (not that java goes for 100 cols,
> not
> > 80)
> 
> I ran 'git cl format' on the while CL and that fixed this and a few other
> indents. (unless we don't want to do that during upstreaming to avoid
increased
> diffcounts, in which case, I will revert the other changes)

The problem is that it's not a "fix". Perhaps it doesn't know that java code is
permitted to be 100 cols

https://codereview.chromium.org/1031003003/diff/40001/chrome/android/shell/ja...
File chrome/android/shell/java/AndroidManifest.xml.jinja2 (right):

https://codereview.chromium.org/1031003003/diff/40001/chrome/android/shell/ja...
chrome/android/shell/java/AndroidManifest.xml.jinja2:204: </receiver>
On 2015/03/25 18:05:25, sadrul wrote:
> Is this the right manifest file to update?

yup

[sadrul, 2015-03-25 19:43:06]

Patchset #4 (id:60001) has been deleted

[sadrul, 2015-03-25 19:51:41]

sadrul@chromium.org changed reviewers:
+ thestig@chromium.org

[sadrul, 2015-03-25 19:51:42]

+thestig@ for chrome/chrome.gyp change

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
(right):

https://codereview.chromium.org/1031003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java:85:
privacyPreferencesManager,
On 2015/03/25 19:06:53, Yaron wrote:
> On 2015/03/25 18:05:24, sadrul wrote:
> > On 2015/03/25 15:16:12, Yaron wrote:
> > > weird indent. please move up to line above (not that java goes for 100
cols,
> > not
> > > 80)
> > 
> > I ran 'git cl format' on the while CL and that fixed this and a few other
> > indents. (unless we don't want to do that during upstreaming to avoid
> increased
> > diffcounts, in which case, I will revert the other changes)
> 
> The problem is that it's not a "fix". Perhaps it doesn't know that java code
is
> permitted to be 100 cols

I reverted the 'cl format' changes.

[Lei Zhang, 2015-03-25 20:47:49]

https://codereview.chromium.org/1031003003/diff/80001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/1031003003/diff/80001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:2912:
'../components/components.gyp:precache_javatests',
Should there be a GN precache_javatests target, and a dependency from
chrome/android/BUILD.gn?

[sadrul, 2015-03-25 22:21:02]

Patchset #5 (id:100001) has been deleted

[sadrul, 2015-03-25 22:25:33]

https://codereview.chromium.org/1031003003/diff/80001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/1031003003/diff/80001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:2912:
'../components/components.gyp:precache_javatests',
On 2015/03/25 20:47:49, Lei Zhang wrote:
> Should there be a GN precache_javatests target, and a dependency from
> chrome/android/BUILD.gn?

Whoops. You are right. I have added the precache_javatests target for gn in the
new patchset. However, it looks like we don't need to add an explicit dependency
for this in chrome/android/BUILD.gn, since chrome/chrome_tests.gni gets these
from this file (chrome_tests.gypi).

[Lei Zhang, 2015-03-25 22:33:56]

lgtm

[sadrul, 2015-03-25 23:13:48]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2015-03-25 23:13:48]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1031003003/#ps120001
(title: ".")

[commit-bot: I haz the power, 2015-03-25 23:15:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1031003003/120001

[commit-bot: I haz the power, 2015-03-26 02:08:35]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-03-26 02:09:16]

Patchset 5 (id:??) landed as
https://crrev.com/efb5a13547940947b2c8f42a4e9ed64d45bdd2d2
Cr-Commit-Position: refs/heads/master@{#322298}

[alex clarke (OOO till 29th), 2015-03-26 11:23:23]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/1032273004/ by alexclarke@chromium.org.

The reason for reverting is: This broke downstream chrome for android. 
Coordination with chrome os is required. See bug for more details..