Issue 1030963005: Remove the |style| parameter from Material

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1030963005: Remove the |style| parameter from Material (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, ojan

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove the |style| parameter from Material There's no reason for Material to take a |style| parameter anymore. Clients can simply use StyleNode instead. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b75b730cdc9e854f7fadc25313bdc8f53c8a4a4e

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -33 lines)			Patch
M	sky/framework/components/button.dart	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	sky/framework/components/drawer.dart	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
M	sky/framework/components/floating_action_button.dart	View		2 chunks	+3 lines, -9 lines	0 comments	Download
M	sky/framework/components/material.dart	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	sky/framework/components/popup_menu.dart	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 9 months ago (2015-03-25 17:42:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b75b730cdc9e854f7fadc25313bdc8f53c8a4a4e (presubmit successful).