Use networkingPrivate types in JS

Use networkingPrivate types in JS

This CL:
* Eliminates cr_onc_types.js, using networkingPrivate types instead
* Uses networkingPrivate types where possible in internet_detail.js

Note: Some ONC types are invalid JS tags, e.g. WEP-PSK or 8021x. As such, we can not currently use them as enum values in the IDL. These types are treated as strings for now. This is arguably a minor regression from using CrOncTypes, but preferable to maintaining the extra JS module. The types (DOMString) still match and can be checked by the closure compiler.

BUG=470262

[stevenjb, 2015-03-24 21:58:13]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2015-03-24 22:12:38]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, jlklein@chromium.org, michaelpg@chromium.org,
pneubeck@chromium.org

[stevenjb, 2015-03-25 22:29:27]

stevenjb@chromium.org changed reviewers:
+ asargent@chromium.org

[stevenjb, 2015-03-25 22:29:28]

This is ready for review.

+asargent@, ptal at networking_private.idl. I copied the existing (sparse)
documentation. Our plan is to migrate the ONC spec to this IDL but for now
rather than have maintain documentation in two places we refer to the ONC
documentation for types and other details.

[Dan Beam, 2015-03-25 22:34:17]

https://codereview.chromium.org/1030963003/diff/40001/third_party/closure_com...
File third_party/closure_compiler/externs/chrome_extensions.js (left):

https://codereview.chromium.org/1030963003/diff/40001/third_party/closure_com...
third_party/closure_compiler/externs/chrome_extensions.js:8237: /**
please update this internally first/as well

[stevenjb, 2015-03-25 22:37:27]

https://codereview.chromium.org/1030963003/diff/40001/third_party/closure_com...
File third_party/closure_compiler/externs/chrome_extensions.js (left):

https://codereview.chromium.org/1030963003/diff/40001/third_party/closure_com...
third_party/closure_compiler/externs/chrome_extensions.js:8237: /**
On 2015/03/25 22:34:17, Dan Beam wrote:
> please update this internally first/as well

I don't understand your comment.

[pneubeck (no reviews), 2015-03-26 16:56:47]

just a few early comments.

https://codereview.chromium.org/1030963003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/1030963003/diff/40001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/internet_detail.js:547: var source =
(onc && onc.getSource()) || 'None';
please comment on the intention here.
I guess that you want to change an undefined source to 'None'.
If possible keep this separate if it's unrelated from the remainder of this CL.

https://codereview.chromium.org/1030963003/diff/40001/extensions/common/api/n...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/1030963003/diff/40001/extensions/common/api/n...
extensions/common/api/networking_private.idl:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
you should run chrome/common/extensions/docs/server2/preview.py
to see whether the generated documentation page is acceptable.
Probably you have to tweak it using [noinline] attributes.

https://codereview.chromium.org/1030963003/diff/40001/extensions/common/api/n...
extensions/common/api/networking_private.idl:6: // network connections
(Cellular, Ethernet, VPN, WiFi" or WiMAX). This private
nit: remove orphaned "

https://codereview.chromium.org/1030963003/diff/40001/extensions/common/api/n...
extensions/common/api/networking_private.idl:33: dictionary APNProperties {
if you don't need for any of these the generated C++ wrappers, you should add
[nocompile] attributes.

[stevenjb, 2015-03-26 18:38:42]

stevenjb@chromium.org changed reviewers:
- asargent@chromium.org

[stevenjb, 2015-03-26 18:38:43]

I've extracted the IDL changes into https://codereview.chromium.org/1038873004/
and https://codereview.chromium.org/1036033002/

Once those are reviewed and committed, I can make the changes to
third_party/closure_compiler/externs/chrome_extensions.js in the appropriate
repository and remove them from this CL.

In the meanwhile, feel free to review this or wait for the other CLs to land (I
will update this when they do).

Thanks!

[stevenjb, 2015-03-30 22:27:46]

This has been rebased with the recent changes to networking_private.idl. It is
ready for review with the caveat that the changes to chrome_extensions.js will
need to be made separately before this can be committed.

[michaelpg, 2015-03-31 19:18:46]

re substituting strings for CrOnc types -- so we just have to be really careful
not to mistype a string value?

https://codereview.chromium.org/1030963003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/network_ui/network_ui.js (right):

https://codereview.chromium.org/1030963003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/network_ui/network_ui.js:61: * @param
{!chrome.networkingPrivate.NetworkStateProperties} networkState The
lol @ being able to fit 1 word of description. I guess it's unavoidable though.

https://codereview.chromium.org/1030963003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/1030963003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/options/chromeos/internet_detail.js:547: var source =
(onc && onc.getSource()) || 'None';
why this change?

https://codereview.chromium.org/1030963003/diff/100001/ui/webui/resources/cr_...
File ui/webui/resources/cr_elements/cr_onc/cr_onc_data.js (right):

https://codereview.chromium.org/1030963003/diff/100001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/cr_onc/cr_onc_data.js:33:
chrome.networkingPrivate.ConnectionStateType.Connected;
4 spaces 33, 39

[stevenjb, 2015-04-17 16:45:51]

Closing this issue. There is active work on auto generating ALL_CAPS enums for
extension APIs. We will need to add support for { _8021X: '8021x' } but {
FOO_BAR: 'foo-bar' } should already be working. Once __8021X is supported we
should be good to go. Note, this is not a priority at this point.