Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 103093004: Remove PPB_Ext_Alarms_Dev and PPB_Ext_Events_Dev. (Closed)

Created:
7 years ago by yzshen1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, raymes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, Sam Clegg, nfullagar1, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Remove PPB_Ext_Alarms_Dev and PPB_Ext_Events_Dev. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1434 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 3 chunks +0 lines, -8 lines 0 comments Download
D ppapi/api/extensions/dev/ppb_ext_alarms_dev.idl View 1 chunk +0 lines, -178 lines 0 comments Download
D ppapi/api/extensions/dev/ppb_ext_events_dev.idl View 1 chunk +0 lines, -87 lines 0 comments Download
D ppapi/c/extensions/dev/ppb_ext_alarms_dev.h View 1 chunk +0 lines, -204 lines 0 comments Download
D ppapi/c/extensions/dev/ppb_ext_events_dev.h View 1 chunk +0 lines, -120 lines 0 comments Download
D ppapi/cpp/extensions/dev/alarms_dev.h View 1 chunk +0 lines, -117 lines 0 comments Download
D ppapi/cpp/extensions/dev/alarms_dev.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D ppapi/cpp/extensions/dev/events_dev.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ppapi/cpp/extensions/dev/events_dev.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D ppapi/cpp/extensions/event_base.h View 1 chunk +0 lines, -232 lines 0 comments Download
D ppapi/cpp/extensions/event_base.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +0 lines, -74 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_sources.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -2 lines 0 comments Download
D ppapi/thunk/ppb_ext_alarms_thunk.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, David. I think we can remove the old Alarms interface to avoid confusion and ...
7 years ago (2013-12-06 18:00:36 UTC) #1
dmichael (off chromium)
lgtm
7 years ago (2013-12-06 18:03:01 UTC) #2
yzshen1
+binji Hi, Ben. Would you please do an owner review for files in native_client_sdk/? Thanks!
7 years ago (2013-12-06 19:31:30 UTC) #3
binji
native_client_sdk lgtm
7 years ago (2013-12-09 18:13:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/103093004/1
7 years ago (2013-12-09 18:16:37 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-09 20:51:46 UTC) #6
Message was sent while issue was closed. 
Change committed as 239545

Powered by Google App Engine
This is Rietveld 408576698