Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: components/metrics/call_stack_profile_metrics_provider_unittest.cc

Issue 1030923002: StackSamplingProfiler clean up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: rebase and update components/metrics Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/call_stack_profile_metrics_provider_unittest.cc
diff --git a/components/metrics/call_stack_profile_metrics_provider_unittest.cc b/components/metrics/call_stack_profile_metrics_provider_unittest.cc
index 20e53d60775903c6624d995af32634b3e6bf9274..b2d01a6574cca63fbc25e4401c1839426062d0b2 100644
--- a/components/metrics/call_stack_profile_metrics_provider_unittest.cc
+++ b/components/metrics/call_stack_profile_metrics_provider_unittest.cc
@@ -12,7 +12,7 @@
using base::StackSamplingProfiler;
using Frame = StackSamplingProfiler::Frame;
using Module = StackSamplingProfiler::Module;
-using Profile = StackSamplingProfiler::Profile;
+using Profile = StackSamplingProfiler::CallStackProfile;
Ilya Sherman 2015/04/01 00:27:46 nit: Should this be CallStackProfile now?
Mike Wittman 2015/04/01 00:48:50 No, we already have a CallStackProfile in metrics,
using Sample = StackSamplingProfiler::Sample;
namespace metrics {
@@ -382,8 +382,8 @@ TEST(CallStackProfileMetricsProviderTest, RepeatedStacksOrdered) {
// Checks that unknown modules produce an empty Entry.
TEST(CallStackProfileMetricsProviderTest, UnknownModule) {
- // -1 indicates an unknown module.
- const Frame frame(reinterpret_cast<const void*>(0x1000), -1);
+ const Frame frame(reinterpret_cast<const void*>(0x1000),
+ Frame::kUnknownModuleIndex);
Profile profile;

Powered by Google App Engine
This is Rietveld 408576698