Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2484)

Unified Diff: chrome/browser/autocomplete/scored_history_match.cc

Issue 1030913002: Omnibox - HQP - Frequency Scoring Bug Fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/scored_history_match.cc
diff --git a/chrome/browser/autocomplete/scored_history_match.cc b/chrome/browser/autocomplete/scored_history_match.cc
index 297ff6c5546b43306ad875cdfed81e7618a6a20b..d2746ddf36bbb9c60e1203f431ecfaea27f9601d 100644
--- a/chrome/browser/autocomplete/scored_history_match.cc
+++ b/chrome/browser/autocomplete/scored_history_match.cc
@@ -585,10 +585,10 @@ float ScoredHistoryMatch::GetFrequency(const base::Time& now,
const size_t max_visit_to_score =
std::min(visits.size(), ScoredHistoryMatch::kMaxVisitsToScore);
for (size_t i = 0; i < max_visit_to_score; ++i) {
- const bool typed_visit = fix_frequency_bugs_ ?
- (visits[i].second & ui::PAGE_TRANSITION_TYPED) :
- (visits[i].second == ui::PAGE_TRANSITION_TYPED);
- int value_of_transition = typed_visit ? 20 : 1;
+ const ui::PageTransition page_transition = fix_frequency_bugs_ ?
+ ui::PageTransitionStripQualifier(visits[i].second) : visits[i].second;
+ int value_of_transition =
+ (page_transition == ui::PAGE_TRANSITION_TYPED) ? 20 : 1;
if (bookmarked)
value_of_transition = std::max(value_of_transition, bookmark_value_);
const float bucket_weight =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698