Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1030883003: Disable OriginReplicationAllowsAccessToStorage test. (Closed)

Created:
5 years, 9 months ago by alexmos
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, site-isolation-reviews_chromium.org, kenrb, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ChromeSitePerProcessTest.OriginReplicationAllowsAccessToStorage test. The test sometimes triggers a shutdown race condition that results in a UAF in blink::FocusController::focusedOrMainFrame() in the renderer, due to WebFrameWidgetImpl outliving Page. Disabling the test until this is fixed. BUG=470055, 468319 Committed: https://crrev.com/66e181bccca3e36cd96252bfe00741cfb916ffef Cr-Commit-Position: refs/heads/master@{#322053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
alexmos
thakis@: could you please take a look?
5 years, 9 months ago (2015-03-24 17:21:27 UTC) #2
Nico
This used to not crash until very recently. What changed?
5 years, 9 months ago (2015-03-24 18:40:45 UTC) #3
alexmos
On 2015/03/24 18:40:45, Nico wrote: > This used to not crash until very recently. What ...
5 years, 9 months ago (2015-03-24 19:12:26 UTC) #4
Nico
ok, lgtm. please mark the bugs as blockers of the --site-per-process tracking bug
5 years, 9 months ago (2015-03-24 19:40:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030883003/1
5 years, 9 months ago (2015-03-24 19:52:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 19:57:08 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/66e181bccca3e36cd96252bfe00741cfb916ffef Cr-Commit-Position: refs/heads/master@{#322053}
5 years, 9 months ago (2015-03-24 19:58:08 UTC) #9
dcheng
5 years, 4 months ago (2015-07-28 21:05:15 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1261973002/ by dcheng@chromium.org.

The reason for reverting is: RenderWidgets should be cleaned up properly now..

Powered by Google App Engine
This is Rietveld 408576698