Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1030803002: Restore the architecture check for Pepper plugins. (Closed)

Created:
5 years, 9 months ago by Will Harris
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore the architecture check for Pepper plugins. Latest version of PepperFlash now includes the correct x-ppapi-arch on x64, so commit 0bc0349 can be safely reverted. BUG=458894 Committed: https://crrev.com/e3b1bfc1831c6d78964d0636c63f3b1ab4ec06f4 Cr-Commit-Position: refs/heads/master@{#322058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/common/pepper_flash.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/data/components/flapper/windows_x64/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Will Harris
PTAL
5 years, 9 months ago (2015-03-24 04:57:47 UTC) #2
cpu_(ooo_6.6-7.5)
thanks for following up with this. LGTM
5 years, 9 months ago (2015-03-24 19:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030803002/1
5 years, 9 months ago (2015-03-24 19:17:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 20:10:56 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 20:11:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b1bfc1831c6d78964d0636c63f3b1ab4ec06f4
Cr-Commit-Position: refs/heads/master@{#322058}

Powered by Google App Engine
This is Rietveld 408576698