Chromium Code Reviews

Issue 1030793002: Make compile without ICE_THREAD_LOCAL_HACK (avoid "Type *TLS = TLS;") (Closed)

Created:
5 years, 9 months ago by jvoung (off chromium)
Modified:
5 years, 9 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make compile without ICE_THREAD_LOCAL_HACK (avoid "Type *TLS = TLS;") Otherwise you get: In file included from src/IceGlobalContext.cpp:21: In file included from src/IceCfg.h:21: src/IceGlobalContext.h:257:44: error: variable 'TLS' is uninitialized when used within its own initialization [-Werror,-Wuninitialized] ThreadContext *TLS = ICE_TLS_GET_FIELD(TLS); ~~~ ^~~ src/IceTLS.h:95:39: note: expanded from macro 'ICE_TLS_GET_FIELD' ^ So rename the local var to Tls. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3e5009f643a931184cf3437e7204e40c7a61d4d1

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+15 lines, -15 lines)
M src/IceGlobalContext.h View 1 chunk +15 lines, -15 lines 0 comments

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 9 months ago (2015-03-24 01:19:38 UTC) #2
Jim Stichnoth
lgtm
5 years, 9 months ago (2015-03-24 01:34:12 UTC) #3
jvoung (off chromium)
5 years, 9 months ago (2015-03-24 16:04:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e5009f643a931184cf3437e7204e40c7a61d4d1 (presubmit successful).

Powered by Google App Engine