Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: components/suggestions/suggestions_service.cc

Issue 1030713002: [Suggestions] Remove support for a Control logging group. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: size fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.cc
diff --git a/components/suggestions/suggestions_service.cc b/components/suggestions/suggestions_service.cc
index fee193e2f597850bb7dbe1af9143d79e89c6a02a..dbc70368b15cc6e421e15bc3c64e0c14bd012586 100644
--- a/components/suggestions/suggestions_service.cc
+++ b/components/suggestions/suggestions_service.cc
@@ -17,7 +17,6 @@
#include "components/suggestions/blacklist_store.h"
#include "components/suggestions/suggestions_store.h"
#include "components/variations/net/variations_http_header_provider.h"
-#include "components/variations/variations_associated_data.h"
#include "net/base/escape.h"
#include "net/base/load_flags.h"
#include "net/base/net_errors.h"
@@ -51,12 +50,6 @@ void LogResponseState(SuggestionsResponseState state) {
RESPONSE_STATE_SIZE);
}
-// Obtains the experiment parameter under the supplied |key|, or empty string
-// if the parameter does not exist.
-std::string GetExperimentParam(const std::string& key) {
- return variations::GetVariationParamValue(kSuggestionsFieldTrialName, key);
-}
-
GURL BuildBlacklistRequestURL(const std::string& blacklist_url_prefix,
const GURL& candidate_url) {
return GURL(blacklist_url_prefix +
@@ -88,11 +81,6 @@ const int kSchedulingMaxDelaySec = 5 * 60;
} // namespace
-const char kSuggestionsFieldTrialName[] = "ChromeSuggestions";
-const char kSuggestionsFieldTrialControlParam[] = "control";
-const char kSuggestionsFieldTrialStateEnabled[] = "enabled";
-const char kSuggestionsFieldTrialStateParam[] = "state";
-
// TODO(mathp): Put this in TemplateURL.
const char kSuggestionsURL[] = "https://www.google.com/chromesuggestions?t=2";
const char kSuggestionsBlacklistURLPrefix[] =
@@ -118,12 +106,6 @@ SuggestionsService::SuggestionsService(
SuggestionsService::~SuggestionsService() {}
-// static
-bool SuggestionsService::IsControlGroup() {
- return GetExperimentParam(kSuggestionsFieldTrialControlParam) ==
- kSuggestionsFieldTrialStateEnabled;
-}
-
void SuggestionsService::FetchSuggestionsData(
SyncState sync_state,
SuggestionsService::ResponseCallback callback) {
« no previous file with comments | « components/suggestions/suggestions_service.h ('k') | components/suggestions/suggestions_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698