[Suggestions] Remove support for a Control logging group.

[Suggestions] Remove support for a Control logging group.

Histograms that are no longer logged:
NewTabPage.MostVisited.client0
NewTabPage.SuggestionsImpression.client0

Field trials that are deprecated: ChromeSuggestions

Cleanup in the tests as well.

TBR=mgiuca
BUG=None
TEST=SuggestionsServiceTest*

Committed: https://crrev.com/d91e8eb029063e12650f3e325f66e9c402e4b949
Cr-Commit-Position: refs/heads/master@{#322025}

[Mathieu, 2015-03-23 19:42:31]

Patchset #1 (id:1) has been deleted

[Mathieu, 2015-03-23 19:48:48]

mathp@chromium.org changed reviewers:
+ newt@chromium.org

[Mathieu, 2015-03-23 19:48:54]

Patchset #1 (id:20001) has been deleted

[Mathieu, 2015-03-23 19:49:06]

Newton, please take a look!

[newt (away), 2015-03-24 00:37:49]

most_visited_sites lgtm

other code looks reasonable, but I'm not familiar with it

[Mathieu, 2015-03-24 12:28:59]

mathp@chromium.org changed reviewers:
+ huangs@chromium.org

[Mathieu, 2015-03-24 12:29:13]

+Sam

Sam, can you have a look at the suggestions/ part?

[huangs, 2015-03-24 13:15:26]

Please state in description the changes in UMA and field trails, so
"NewTabPage.MostVisited.client0" and "NewTabPage.SuggestionsImpression.client0"
disappear, and
ChromeSuggestions/{control,enable,state} are gone.

[Mathieu, 2015-03-24 15:01:14]

I've updated the description and cleaned up one more test.

[huangs, 2015-03-24 15:17:27]

Question on MostVisitedSites change.

https://codereview.chromium.org/1030713002/diff/60001/chrome/browser/android/...
File chrome/browser/android/most_visited_sites.cc (right):

https://codereview.chromium.org/1030713002/diff/60001/chrome/browser/android/...
chrome/browser/android/most_visited_sites.cc:406: std::vector<base::string16>
titles;
So if size == 0 you no longer need to call InitiateTopSitesQuery()?  Would this
be a change in behavior?

[Mathieu, 2015-03-24 15:26:16]

Big thanks!

https://codereview.chromium.org/1030713002/diff/60001/chrome/browser/android/...
File chrome/browser/android/most_visited_sites.cc (right):

https://codereview.chromium.org/1030713002/diff/60001/chrome/browser/android/...
chrome/browser/android/most_visited_sites.cc:406: std::vector<base::string16>
titles;
On 2015/03/24 15:17:26, huangs wrote:
> So if size == 0 you no longer need to call InitiateTopSitesQuery()?  Would
this
> be a change in behavior?

Done. Gosh, I feel so silly :\

[huangs, 2015-03-24 15:28:56]

No worries.  LGTM.

[Mathieu, 2015-03-24 16:25:43]

TBR mgiuca for the modified test in app_list

Thanks

[Mathieu, 2015-03-24 16:25:47]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2015-03-24 16:25:47]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1030713002/#ps80001
(title: "size fix")

[commit-bot: I haz the power, 2015-03-24 16:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030713002/80001

[commit-bot: I haz the power, 2015-03-24 17:38:02]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-03-24 17:39:12]

Patchset 3 (id:??) landed as
https://crrev.com/d91e8eb029063e12650f3e325f66e9c402e4b949
Cr-Commit-Position: refs/heads/master@{#322025}