Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1030693002: [Telemetry] Expect to skip smoothness.maps on low-end devices (Closed)

Created:
5 years, 9 months ago by eakuefner
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Expect to skip smoothness.maps on low-end devices Certain devices have ARM GPUs that report support of certain WebGL features but fail to actually support them, causing smoothness.maps to fail. This CL adds WebGLLowEndExpectations to skip tests like smoothness.maps on such devices. BUG=464731 R=dtu,kbr@chromium.org,sullivan Committed: https://crrev.com/09076881792dc0f91937592ba713b1f64598766b Cr-Commit-Position: refs/heads/master@{#321848}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/perf/benchmarks/smoothness.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/webgl_expectations.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
eakuefner
Please take a look.
5 years, 9 months ago (2015-03-23 16:18:49 UTC) #1
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/1030693002/diff/1/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1030693002/diff/1/tools/perf/benchmarks/smoothness.py#newcode74 tools/perf/benchmarks/smoothness.py:74: return webgl_expectations.WebGLLowEndExpectations() I'd suggest naming these expectations per ...
5 years, 9 months ago (2015-03-23 18:08:03 UTC) #2
eakuefner
https://codereview.chromium.org/1030693002/diff/1/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1030693002/diff/1/tools/perf/benchmarks/smoothness.py#newcode74 tools/perf/benchmarks/smoothness.py:74: return webgl_expectations.WebGLLowEndExpectations() On 2015/03/23 18:08:03, Ken Russell wrote: > ...
5 years, 9 months ago (2015-03-23 18:11:27 UTC) #3
dtu
lgtm
5 years, 9 months ago (2015-03-23 19:43:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030693002/20001
5 years, 9 months ago (2015-03-23 19:46:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 21:04:39 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:06:02 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09076881792dc0f91937592ba713b1f64598766b
Cr-Commit-Position: refs/heads/master@{#321848}

Powered by Google App Engine
This is Rietveld 408576698