Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: src/array.js

Issue 1030673002: Make debugger step into bound callbacks passed to Array.forEach. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/collection.js » ('j') | src/runtime/runtime-debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index 12d2b4c22ae73127236c6e3c189a1e4eec7bf888..62f9073fb11da599746ba028c984434d08a9281e 100644
--- a/src/array.js
+++ b/src/array.js
@@ -1156,7 +1156,7 @@ function ArrayFilter(f, receiver) {
var accumulator = new InternalArray();
var accumulator_length = 0;
var is_array = IS_ARRAY(array);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
+ var stepping = DEBUG_IS_STEPPING();
for (var i = 0; i < length; i++) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
@@ -1192,7 +1192,7 @@ function ArrayForEach(f, receiver) {
}
var is_array = IS_ARRAY(array);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
+ var stepping = DEBUG_IS_STEPPING();
for (var i = 0; i < length; i++) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
@@ -1226,7 +1226,7 @@ function ArraySome(f, receiver) {
}
var is_array = IS_ARRAY(array);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
+ var stepping = DEBUG_IS_STEPPING();
for (var i = 0; i < length; i++) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
@@ -1259,7 +1259,7 @@ function ArrayEvery(f, receiver) {
}
var is_array = IS_ARRAY(array);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
+ var stepping = DEBUG_IS_STEPPING();
for (var i = 0; i < length; i++) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
@@ -1293,7 +1293,7 @@ function ArrayMap(f, receiver) {
var result = new $Array();
var accumulator = new InternalArray(length);
var is_array = IS_ARRAY(array);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
+ var stepping = DEBUG_IS_STEPPING();
for (var i = 0; i < length; i++) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
@@ -1443,7 +1443,7 @@ function ArrayReduce(callback, current) {
}
var receiver = %GetDefaultReceiver(callback);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(callback);
+ var stepping = DEBUG_IS_STEPPING();
for (; i < length; i++) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
@@ -1480,7 +1480,7 @@ function ArrayReduceRight(callback, current) {
}
var receiver = %GetDefaultReceiver(callback);
- var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(callback);
+ var stepping = DEBUG_IS_STEPPING();
for (; i >= 0; i--) {
if (HAS_INDEX(array, i, is_array)) {
var element = array[i];
« no previous file with comments | « no previous file | src/collection.js » ('j') | src/runtime/runtime-debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698