Make debugger step into bound callbacks passed to Array.forEach.

Make debugger step into bound callbacks passed to Array.forEach.

BUG=chromium:450004
R=yangguo@chromium.org, kozyatinskiy@chromium.org
LOG=N

Committed: https://crrev.com/fc1689392e4c10552878a2ae448ac33735b6aac8
Cr-Commit-Position: refs/heads/master@{#27419}

[kozy, 2015-03-23 16:49:28]

https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:2750: return isolate->heap()->true_value();
Why can we eliminate callback function check?

[Yang, 2015-03-24 07:27:15]

https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (left):

https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:2753: !JSFunction::cast(callback)->IsBuiltin());
Can't we make this change a lot simpler by returning true here for callbacks
where JSFunction::cast(callback)->shared()->bound()?

[aandrey, 2015-03-24 13:18:06]

On 2015/03/24 07:27:15, Yang wrote:
> https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.cc
> File src/runtime/runtime-debug.cc (left):
> 
>
https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.c...
> src/runtime/runtime-debug.cc:2753: !JSFunction::cast(callback)->IsBuiltin());
> Can't we make this change a lot simpler by returning true here for callbacks
> where JSFunction::cast(callback)->shared()->bound()?

Done.
Also added a new test from the bug report.

[Yang, 2015-03-24 13:23:11]

On 2015/03/24 13:18:06, aandrey wrote:
> On 2015/03/24 07:27:15, Yang wrote:
> >
https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.cc
> > File src/runtime/runtime-debug.cc (left):
> > 
> >
>
https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.c...
> > src/runtime/runtime-debug.cc:2753:
!JSFunction::cast(callback)->IsBuiltin());
> > Can't we make this change a lot simpler by returning true here for callbacks
> > where JSFunction::cast(callback)->shared()->bound()?
> 
> Done.
> Also added a new test from the bug report.

lgtm.

[aandrey, 2015-03-24 13:25:15]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2015-03-24 13:25:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030673002/20001

[commit-bot: I haz the power, 2015-03-24 13:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 13:37:10]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Yang, 2015-03-24 13:58:18]

On 2015/03/24 13:37:10, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

I think you need to add 
// Flags: --allow-natives-syntax

[aandrey, 2015-03-24 15:14:35]

The CQ bit was checked by aandrey@chromium.org

[aandrey, 2015-03-24 15:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1030673002/#ps40001
(title: "fixed test")

[commit-bot: I haz the power, 2015-03-24 15:14:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030673002/40001

[commit-bot: I haz the power, 2015-03-24 16:02:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-24 16:02:25]

Patchset 3 (id:??) landed as
https://crrev.com/fc1689392e4c10552878a2ae448ac33735b6aac8
Cr-Commit-Position: refs/heads/master@{#27419}