Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1030653002: remove meaningless matrix benches, add mapPts() and add new benches (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove meaningless matrix benches, add mapPts() and add new benches mapPts definitely faster than mapPoints (identity and perspective same speed). Up to 3x for large values of N. cloned from https://codereview.chromium.org/1031443002/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/8010632f2408ce9d840c1dcd26a8be0e4967233e

Patch Set 1 #

Patch Set 2 : remove loop-unrolling for now (separate CL perhaps) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -205 lines) Patch
M bench/MatrixBench.cpp View 4 chunks +46 lines, -205 lines 0 comments Download
M include/core/SkMatrix.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkMatrix.cpp View 1 1 chunk +84 lines, -0 lines 0 comments Download
M tests/MatrixTest.cpp View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
ptal
5 years, 9 months ago (2015-03-23 15:10:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030653002/20001
5 years, 9 months ago (2015-03-23 15:10:08 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-23 15:10:09 UTC) #5
caryclark
lgtm
5 years, 9 months ago (2015-03-23 15:13:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 15:15:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8010632f2408ce9d840c1dcd26a8be0e4967233e

Powered by Google App Engine
This is Rietveld 408576698