Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1030623003: [turbofan] Fix control reducer bug with walking non-control edges during ConnectNTL phase. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix control reducer bug with walking non-control edges during ConnectNTL phase. R=jarin@chromium.org BUG=chromium:469605 LOG=Y Committed: https://crrev.com/d931700b81a418e3c8e0e0f5d3ee886807c987c1 Cr-Commit-Position: refs/heads/master@{#27366}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -31 lines) Patch
M src/compiler/control-reducer.cc View 1 5 chunks +37 lines, -31 lines 0 comments Download
A test/mjsunit/regress/regress-469605.js View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
titzer
5 years, 9 months ago (2015-03-23 12:50:37 UTC) #1
titzer
PTAL
5 years, 9 months ago (2015-03-23 13:05:44 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-23 13:29:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030623003/40001
5 years, 9 months ago (2015-03-23 13:48:12 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 14:08:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 14:08:33 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d931700b81a418e3c8e0e0f5d3ee886807c987c1
Cr-Commit-Position: refs/heads/master@{#27366}

Powered by Google App Engine
This is Rietveld 408576698