Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequest.h

Issue 1030613002: [bindings] Make XMLHttpRequest.send() use the generated binding code over the custom one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Cover both paths for InspectorInstrumentation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xmlhttprequest/XMLHttpRequest.h
diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.h b/Source/core/xmlhttprequest/XMLHttpRequest.h
index acac3301a69af2d323758a9cac70b099deee0002..cef223af1cad9d7dd80901691b8d1d673e7f3f33 100644
--- a/Source/core/xmlhttprequest/XMLHttpRequest.h
+++ b/Source/core/xmlhttprequest/XMLHttpRequest.h
@@ -41,6 +41,7 @@
namespace blink {
+class ArrayBufferOrArrayBufferViewOrBlobOrDocumentOrHTMLDocumentOrStringOrFormData;
yhirano 2015/03/23 11:50:41 Sorry that I don't know much about union, should w
vivekg 2015/03/23 11:57:36 Yes I think this needs to be fixed in the bindings
Jens Widell 2015/03/23 12:03:04 If we only have Document, all types of documents w
class Blob;
class BlobDataHandle;
class DOMArrayBuffer;
@@ -116,12 +117,7 @@ public:
void open(const AtomicString& method, const KURL&, bool async, const String& user, ExceptionState&);
void open(const AtomicString& method, const KURL&, bool async, const String& user, const String& password, ExceptionState&);
void send(ExceptionState&);
- void send(Document*, ExceptionState&);
- void send(const String&, ExceptionState&);
- void send(Blob*, ExceptionState&);
- void send(DOMFormData*, ExceptionState&);
- void send(DOMArrayBuffer*, ExceptionState&);
- void send(DOMArrayBufferView*, ExceptionState&);
+ void send(const ArrayBufferOrArrayBufferViewOrBlobOrDocumentOrHTMLDocumentOrStringOrFormData&, ExceptionState&);
void abort();
void setRequestHeader(const AtomicString& name, const AtomicString& value, ExceptionState&);
void overrideMimeType(const AtomicString& override, ExceptionState&);
@@ -204,6 +200,12 @@ private:
bool initSend(ExceptionState&);
void sendBytesData(const void*, size_t, ExceptionState&);
+ void send(Document*, ExceptionState&);
+ void send(const String&, ExceptionState&);
+ void send(Blob*, ExceptionState&);
+ void send(DOMFormData*, ExceptionState&);
+ void send(DOMArrayBuffer*, ExceptionState&);
+ void send(DOMArrayBufferView*, ExceptionState&);
const AtomicString& getRequestHeader(const AtomicString& name) const;
void setRequestHeaderInternal(const AtomicString& name, const AtomicString& value);

Powered by Google App Engine
This is Rietveld 408576698