Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 1030613002: [bindings] Make XMLHttpRequest.send() use the generated binding code over the custom one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
index 883fb9f3e84237435e8dfef860aeb23180145da8..048603f1915d5a34a911096f1056597b7a105abd 100644
--- a/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
@@ -200,57 +200,4 @@ void V8XMLHttpRequest::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value
exceptionState.throwIfNeeded();
}
-static bool isDocumentType(v8::Handle<v8::Value> value, v8::Isolate* isolate)
-{
- // FIXME: add other document types.
- return V8Document::hasInstance(value, isolate) || V8HTMLDocument::hasInstance(value, isolate);
-}
-
-void V8XMLHttpRequest::sendMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toImpl(info.Holder());
-
- InspectorInstrumentation::willSendXMLHttpRequest(xmlHttpRequest->executionContext(), xmlHttpRequest->url());
-
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "send", "XMLHttpRequest", info.Holder(), info.GetIsolate());
- if (info.Length() < 1) {
- xmlHttpRequest->send(exceptionState);
- } else {
- v8::Handle<v8::Value> arg = info[0];
- if (isUndefinedOrNull(arg)) {
- xmlHttpRequest->send(exceptionState);
- } else if (isDocumentType(arg, info.GetIsolate())) {
- v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(arg);
- Document* document = V8Document::toImpl(object);
- ASSERT(document);
- xmlHttpRequest->send(document, exceptionState);
- } else if (V8Blob::hasInstance(arg, info.GetIsolate())) {
- v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(arg);
- Blob* blob = V8Blob::toImpl(object);
- ASSERT(blob);
- xmlHttpRequest->send(blob, exceptionState);
- } else if (V8FormData::hasInstance(arg, info.GetIsolate())) {
- v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(arg);
- DOMFormData* domFormData = V8FormData::toImpl(object);
- ASSERT(domFormData);
- xmlHttpRequest->send(domFormData, exceptionState);
- } else if (V8ArrayBuffer::hasInstance(arg, info.GetIsolate())) {
- v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(arg);
- DOMArrayBuffer* arrayBuffer = V8ArrayBuffer::toImpl(object);
- ASSERT(arrayBuffer);
- xmlHttpRequest->send(arrayBuffer, exceptionState);
- } else if (V8ArrayBufferView::hasInstance(arg, info.GetIsolate())) {
- v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(arg);
- DOMArrayBufferView* arrayBufferView = V8ArrayBufferView::toImpl(object);
- ASSERT(arrayBufferView);
- xmlHttpRequest->send(arrayBufferView, exceptionState);
- } else {
- TOSTRING_VOID(V8StringResource<TreatNullAsNullString>, argString, arg);
- xmlHttpRequest->send(argString, exceptionState);
- }
- }
-
- exceptionState.throwIfNeeded();
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698