[bindings] Make XMLHttpRequest.send() use the generated binding code over the custom one.

Source/core/xmlhttprequest/XMLHttpRequest.cpp

 /*
  *  Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
  *  Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
  *  Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
  *  Copyright (C) 2008, 2011 Google Inc. All rights reserved.
  *  Copyright (C) 2012 Intel Corporation
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Lesser General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Lesser General Public License for more details.
  *
  *  You should have received a copy of the GNU Lesser General Public
  *  License along with this library; if not, write to the Free Software
  *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
 #include "config.h"
 #include "core/xmlhttprequest/XMLHttpRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/UnionTypesCore.h"
 #include "core/dom/ContextFeatures.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/dom/DOMArrayBufferView.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/DOMImplementation.h"
 #include "core/dom/DOMTypedArray.h"
 #include "core/dom/DocumentParser.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/XMLDocument.h"
 #include "core/editing/markup.h"
@@ skipping 749 matching lines @@
 
     if (m_state != OPENED || m_loader) {
         exceptionState.throwDOMException(InvalidStateError, "The object's state must be OPENED.");
         return false;
     }
 
     m_error = false;
     return true;
 }
 
+void XMLHttpRequest::send(const ArrayBufferOrArrayBufferViewOrBlobOrDocumentOrHTMLDocumentOrStringOrFormData& data, ExceptionState& exceptionState)
+{
+    InspectorInstrumentation::willSendXMLHttpRequest(executionContext(), url());
+    if (data.isNull()) {
+        send(exceptionState);
+        return;
+    }
+
+    if (data.isArrayBuffer()) {
+        send(data.getAsArrayBuffer().get(), exceptionState);
+        return;
+    }
+
+    if (data.isArrayBufferView()) {
+        send(data.getAsArrayBufferView().get(), exceptionState);
+        return;
+    }
+
+    if (data.isBlob()) {
+        send(data.getAsBlob(), exceptionState);
+        return;
+    }
+
+    if (data.isDocument() || data.isHTMLDocument()) {
+        Document* document = data.isDocument() ? data.getAsDocument().get() : data.getAsHTMLDocument().get();
+        send(document, exceptionState);
+        return;
+    }
+
+    if (data.isHTMLDocument()) {

[yhirano, 2015/03/23 11:50:41]

This branch will never be taken.

[vivekg, 2015/03/23 11:57:36]

Right!

+        send(data.getAsHTMLDocument().get(), exceptionState);
+        return;
+    }
+
+    if (data.isFormData()) {
+        send(data.getAsFormData().get(), exceptionState);
+        return;
+    }
+
+    ASSERT(data.isString());
+    send(data.getAsString(), exceptionState);
+}
+
 void XMLHttpRequest::send(ExceptionState& exceptionState)
 {
+    InspectorInstrumentation::willSendXMLHttpRequest(executionContext(), url());

[yhirano, 2015/03/23 11:50:41]

Is this change related to the issue?

[vivekg, 2015/03/23 11:57:36]

Yes this is being handled in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
and without this change the following cases fail in inspector:

inspector/sources/debugger/xhr-breakpoints.html
inspector/sources/debugger/frameworks-dom-xhr-event-breakpoints.html

[yhirano, 2015/03/23 12:44:33]

Thanks, I see.

     send(String(), exceptionState);
 }
 
 bool XMLHttpRequest::areMethodAndURLValidForSend()
 {
     return m_method != "GET" && m_method != "HEAD" && m_url.protocolIsInHTTPFamily();
 }
 
 void XMLHttpRequest::send(Document* document, ExceptionState& exceptionState)
 {
@@ skipping 1019 matching lines @@
     visitor->trace(m_responseDocumentParser);
     visitor->trace(m_progressEventThrottle);
     visitor->trace(m_upload);
     visitor->trace(m_blobLoader);
     XMLHttpRequestEventTarget::trace(visitor);
     DocumentParserClient::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink