Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 1030593003: Update README file (Closed)

Created:
5 years, 9 months ago by Søren Gjesse
Modified:
4 years, 4 months ago
Reviewers:
wibling, kustermann
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/gcloud@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update README file. Now it actually have informationon what you cna do with the gcloud package. R=kustermann@google.com, wibling@google.com BUG= Committed: https://github.com/dart-lang/gcloud/commit/b09f3f89e2c0086c39f2808a6741c4425d6fff57

Patch Set 1 #

Patch Set 2 : More text #

Total comments: 28

Patch Set 3 : Addressed comments from kustermann@ #

Total comments: 11

Patch Set 4 : Addressed comments from wibling@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -6 lines) Patch
M README.md View 1 2 3 1 chunk +222 lines, -4 lines 0 comments Download
M lib/storage.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
5 years, 9 months ago (2015-03-24 16:38:05 UTC) #1
kustermann
LGTM https://codereview.chromium.org/1030593003/diff/20001/README.md File README.md (right): https://codereview.chromium.org/1030593003/diff/20001/README.md#newcode44 README.md:44: var jsonCredentials = new File('my-project.json').readAsStringSync()); Remove final ')' ...
5 years, 9 months ago (2015-03-24 17:53:28 UTC) #2
Søren Gjesse
Thanks Martin https://codereview.chromium.org/1030593003/diff/20001/README.md File README.md (right): https://codereview.chromium.org/1030593003/diff/20001/README.md#newcode44 README.md:44: var jsonCredentials = new File('my-project.json').readAsStringSync()); On 2015/03/24 ...
5 years, 9 months ago (2015-03-25 08:28:27 UTC) #3
wibling
Looks good. A few comments below. https://codereview.chromium.org/1030593003/diff/40001/README.md File README.md (right): https://codereview.chromium.org/1030593003/diff/40001/README.md#newcode3 README.md:3: This `gcloud` packages ...
5 years, 9 months ago (2015-03-25 09:59:02 UTC) #4
Søren Gjesse
5 years, 9 months ago (2015-03-25 14:54:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b09f3f89e2c0086c39f2808a6741c4425d6fff57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698