Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1030563002: X87: Remove frame pointer from StackHandler. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove frame pointer from StackHandler. port 36e69a916f2a88664887d2b62f0eaf8400edb182 (r27115) original commit message: This reduces the size of the StackHandler by yet another word. We no longer need to keep track of the frame pointer, as the stack walk will be able to recalculate it. BUG= Committed: https://crrev.com/c1cf472f8cd16e827d6c95f7a045f689bcac7be7 Cr-Commit-Position: refs/heads/master@{#27357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 08:57:55 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-23 09:03:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030563002/1
5 years, 9 months ago (2015-03-23 09:04:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 09:23:10 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 09:23:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1cf472f8cd16e827d6c95f7a045f689bcac7be7
Cr-Commit-Position: refs/heads/master@{#27357}

Powered by Google App Engine
This is Rietveld 408576698