Issue 103053014: Revert of Implement eliding/truncating at end in RenderText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103053014: Revert of Implement eliding/truncating at end in RenderText (Closed)

Created:
7 years ago by szym

Modified:
7 years ago

Reviewers:
Anuj, jungshik at Google, Peter Kasting, msw

CC:
chromium-reviews, tfarina, James Su, erikwright+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/107513011/ Reason for revert: Test fails on main waterfall. TBR=jshin@chromium.org,msw@chromium.org,pkasting@chromium.org,skanuj@chromium.org NOTREECHECKS=true NOTRY=true BUG=327833 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241050

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+305 lines, -445 lines)			Patch
M	base/i18n/rtl.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	base/i18n/rtl.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	base/i18n/rtl_unittest.cc	View	2 chunks	+0 lines, -64 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_result_view.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_result_view.cc	View	1 chunk	+206 lines, -51 lines	0 comments	Download
M	ui/gfx/render_text.h	View	5 chunks	+0 lines, -16 lines	0 comments	Download
M	ui/gfx/render_text.cc	View	7 chunks	+8 lines, -120 lines	0 comments	Download
M	ui/gfx/render_text_unittest.cc	View	1 chunk	+0 lines, -86 lines	0 comments	Download
M	ui/gfx/text_elider.h	View	2 chunks	+1 line, -35 lines	0 comments	Download
M	ui/gfx/text_elider.cc	View	4 chunks	+73 lines, -55 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/103053014/1

7 years ago (2013-12-16 22:26:47 UTC) #2

Anuj

7 years ago (2013-12-20 06:24:36 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/119813002/ by skanuj@chromium.org.

The reason for reverting is: Implementing the original change which was
reverted.

Expand Messages | Collapse Messages