Issue 103053011: Honor svn-remote.*.rewriteRoot option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103053011: Honor svn-remote.*.rewriteRoot option. (Closed)

Created:
7 years ago by szager1

Modified:
7 years ago

Reviewers:
M-A Ruel, blundell

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Honor svn-remote.*.rewriteRoot option. MatchSvnGlob uses the root url to grep for existing svn commits by matching the git-svn-id lines in the commit messages. If there is a rewriteRoot config, then the git-svn-id lines will have the rewritten url's, and the code should match against that. R=blundell@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241043

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	git_cl.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/103053011/1

7 years ago (2013-12-16 22:05:29 UTC) #3

blundell

7 years ago (2013-12-17 09:15:58 UTC) #5

Message was sent while issue was closed.

LGTM

I ran a test and confirmed that this change fixes the problem that I described
in
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/yq1s1oEBn5Y.

Thanks!

Expand Messages | Collapse Messages