Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: components/metrics/metrics_service.h

Issue 1030503003: Metrics log modification to handle external components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add version_utils Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.h
diff --git a/components/metrics/metrics_service.h b/components/metrics/metrics_service.h
index d7a612c83c1b6abde522f47c04dc14430398cf67..67a98422dd2b371ccd41dfc8ac38a23decd39ee8 100644
--- a/components/metrics/metrics_service.h
+++ b/components/metrics/metrics_service.h
@@ -151,6 +151,10 @@ class MetricsService : public base::HistogramFlattener {
// Returns the install date of the application, in seconds since the epoch.
int64 GetInstallDate();
+ // Returns the date at which the current metrics client ID was created as
+ // an int64 containing seconds since the epoch8.
Ilya Sherman 2015/03/23 21:59:29 nit: What's an "epoch8"?
Olivier 2015/03/24 16:28:02 Done.
+ int64 GetMetricsReportingEnabledDate();
+
// Returns the preferred entropy provider used to seed persistent activities
// based on whether or not metrics reporting will be permitted on this client.
//
@@ -243,6 +247,13 @@ class MetricsService : public base::HistogramFlattener {
// Clears the stability metrics that are saved in local state.
void ClearSavedStabilityMetrics();
+ // Sets the connection type callback used to pass to the scheduler.
+ void SetConnectionTypeCallback(
+ base::Callback<void(bool*)> is_cellular_callback);
Ilya Sherman 2015/03/23 21:59:29 Why are these three lines included in the diff?
Olivier 2015/03/24 16:28:02 Done.
+
+ // Pushes a log that has been generated by an external component.
+ void PushExternalLog(const std::string& log);
+
protected:
// Exposed for testing.
MetricsLogManager* log_manager() { return &log_manager_; }

Powered by Google App Engine
This is Rietveld 408576698