Metrics log modification to handle external components.

Metrics log modification to handle external components.

This CL adds methods to extract the content of a log in an external module
and import it to upload in the main application.

BUG=474625
Committed: https://crrev.com/c3dfc5b5b768b2ec656bad6d9ef209a5e690fc5e
Cr-Commit-Position: refs/heads/master@{#324085}

[Olivier, 2015-03-23 12:18:21]

olivierrobin@chromium.org changed reviewers:
+ asvitkine@chromium.org, isherman@chromium.org, pkl@chromium.org

[Ilya Sherman, 2015-03-23 21:59:29]

Thanks!

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS#newc...
chrome/common/DEPS:15: "+components/metrics/proto/system_profile.pb.h",
Can the metrics lines be moved to //chrome/common/metrics/DEPS?

https://codereview.chromium.org/1030503003/diff/20001/components/metrics/metr...
File components/metrics/metrics_service.h (right):

https://codereview.chromium.org/1030503003/diff/20001/components/metrics/metr...
components/metrics/metrics_service.h:155: // an int64 containing seconds since
the epoch8.
nit: What's an "epoch8"?

https://codereview.chromium.org/1030503003/diff/20001/components/metrics/metr...
components/metrics/metrics_service.h:252: base::Callback<void(bool*)>
is_cellular_callback);
Why are these three lines included in the diff?

[Olivier, 2015-03-24 16:28:02]

Thanks

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS#newc...
chrome/common/DEPS:15: "+components/metrics/proto/system_profile.pb.h",
On 2015/03/23 21:59:29, Ilya Sherman wrote:
> Can the metrics lines be moved to //chrome/common/metrics/DEPS?

Only system_profile.pb.h
The other are included in chrome/common files

https://codereview.chromium.org/1030503003/diff/20001/components/metrics/metr...
File components/metrics/metrics_service.h (right):

https://codereview.chromium.org/1030503003/diff/20001/components/metrics/metr...
components/metrics/metrics_service.h:155: // an int64 containing seconds since
the epoch8.
On 2015/03/23 21:59:29, Ilya Sherman wrote:
> nit: What's an "epoch8"?

Done.

https://codereview.chromium.org/1030503003/diff/20001/components/metrics/metr...
components/metrics/metrics_service.h:252: base::Callback<void(bool*)>
is_cellular_callback);
On 2015/03/23 21:59:29, Ilya Sherman wrote:
> Why are these three lines included in the diff?

Done.

[Ilya Sherman, 2015-03-24 18:09:44]

LGTM % a final comment.  Thanks!

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS#newc...
chrome/common/DEPS:15: "+components/metrics/proto/system_profile.pb.h",
On 2015/03/24 16:28:02, Olivier Robin wrote:
> On 2015/03/23 21:59:29, Ilya Sherman wrote:
> > Can the metrics lines be moved to //chrome/common/metrics/DEPS?
> 
> Only system_profile.pb.h
> The other are included in chrome/common files

Okay.  Please move the system_profile.pb.h one.  It's best to keep DEPS files as
focused as possible, both to really nail down dependencies, and also so that
top-level ones don't sprawl.

[Olivier, 2015-03-25 18:09:36]

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS
File chrome/common/DEPS (right):

https://codereview.chromium.org/1030503003/diff/20001/chrome/common/DEPS#newc...
chrome/common/DEPS:15: "+components/metrics/proto/system_profile.pb.h",
On 2015/03/24 18:09:44, Ilya Sherman wrote:
> On 2015/03/24 16:28:02, Olivier Robin wrote:
> > On 2015/03/23 21:59:29, Ilya Sherman wrote:
> > > Can the metrics lines be moved to //chrome/common/metrics/DEPS?
> > 
> > Only system_profile.pb.h
> > The other are included in chrome/common files
> 
> Okay.  Please move the system_profile.pb.h one.  It's best to keep DEPS files
as
> focused as possible, both to really nail down dependencies, and also so that
> top-level ones don't sprawl.

Done.

[Olivier, 2015-03-25 18:31:00]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2015-03-25 18:31:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1030503003/#ps60001
(title: "move deps")

[commit-bot: I haz the power, 2015-03-25 18:31:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030503003/60001

[Ilya Sherman, 2015-03-25 18:34:32]

Looks like you still need an owner to approve the changes to
//chrome/common/metrics, because that directory doesn't have an OWNERS file. 
Feel free to add an OWNERS file as part of this CL :)

https://codereview.chromium.org/1030503003/diff/60001/chrome/common/metrics/DEPS
File chrome/common/metrics/DEPS (right):

https://codereview.chromium.org/1030503003/diff/60001/chrome/common/metrics/D...
chrome/common/metrics/DEPS:4: 
nit: Please remove this extra newline.

[commit-bot: I haz the power, 2015-03-25 18:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 18:51:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexei Svitkine (slow), 2015-03-30 15:08:05]

lgtm, could you associate the change with a crbug though?

[Olivier, 2015-04-07 17:01:04]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2015-04-07 17:01:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1030503003/#ps100001
(title: "newlinewq")

[commit-bot: I haz the power, 2015-04-07 17:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030503003/100001

[commit-bot: I haz the power, 2015-04-07 19:12:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-07 19:13:31]

Patchset 6 (id:??) landed as
https://crrev.com/c3dfc5b5b768b2ec656bad6d9ef209a5e690fc5e
Cr-Commit-Position: refs/heads/master@{#324085}