Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 1030413002: Revert of Allow users to perform queries in the omnibox which begin with a search shortcut. (Closed)

Created:
5 years, 9 months ago by scheib
Modified:
5 years, 9 months ago
Reviewers:
Peter Kasting, khzn, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow users to perform queries in the omnibox which begin with a search shortcut. (patchset #4 id:60001 of https://codereview.chromium.org/477873002/) Reason for revert: Caused a few OmniboxViewTest interactive_ui_tests failures (tests need updating too). build: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/22466 test output: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/501/steps/interactive_ui_tests/logs/OmniboxViewTest.AcceptKeywordBySpace Looks like try jobs weren't run, only commit queue earlier. Unsure why commit queue didn't include this test - but it's recommended to run 'git cl try' on patches and review. Original issue's description: > Allow users to perform queries in the omnibox which begin with a search > shortcut. > > Previously, if a user had (for example) configured a search shortcut of 'cs' which > went to cs.chromium.org, they would be unable to (easily) start a query in the > omnibox starting with 'cs'. Now, backspacing the keyword leaves the space after > the keyword, allowing the user to continue typing without reenabling keyword > mode. > > BUG=393371 > NOTRY=true > R=pkasting@chromium.org > TEST=type 'google.com ' into the omnibar and it should enter keyword mode. > Press backspace and 'google.com ' will be left in the omnibar, rather than > 'google.com'. > > Committed: https://crrev.com/709649607f13acb04e3850d5fd7fc1903c1becae > Cr-Commit-Position: refs/heads/master@{#322429} TBR=pkasting@chromium.org,sky@chromium.org,lenny.khazan@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=393371 Committed: https://crrev.com/52179c1b310fec1797c81ea9a20326839860b7d3 Cr-Commit-Position: refs/heads/master@{#322448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
Created Revert of Allow users to perform queries in the omnibox which begin with a ...
5 years, 9 months ago (2015-03-26 19:30:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030413002/1
5 years, 9 months ago (2015-03-26 19:30:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 19:31:02 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 19:31:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52179c1b310fec1797c81ea9a20326839860b7d3
Cr-Commit-Position: refs/heads/master@{#322448}

Powered by Google App Engine
This is Rietveld 408576698