Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1030403002: [Reland] Port Chromium OS touch noise filtering to Chromium. (Closed)

Created:
5 years, 9 months ago by pkotwicz
Modified:
5 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port Chromium OS touch noise filtering to Chromium. The Chromium OS touch noise filtering is at https://chromium.googlesource.com/chromiumos/platform/touch_noise_filter/+/master When a touch is detected as touch noise, an ET_TOUCH_CANCELLED event is sent and all of the subsequent events for that touch are dropped. A "touch press" initiates a new touch. BUG=407840 TEST=TouchNoiseFinderTest.*, TouchEventConverterEvdevTouchNoiseTest.* R=spang TBR=sadrul Committed: https://crrev.com/b7289d5923c8368faefc03ddb4322a20866b16df Cr-Commit-Position: refs/heads/master@{#322579}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1027 lines, -109 lines) Patch
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/event_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/event_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_evdev_types.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_evdev_types.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 6 chunks +15 lines, -24 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 11 chunks +65 lines, -57 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 10 chunks +184 lines, -28 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/far_apart_taps_touch_noise_filter.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/far_apart_taps_touch_noise_filter.cc View 1 chunk +91 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/horizontally_aligned_touch_noise_filter.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/single_position_touch_noise_filter.h View 1 chunk +55 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/single_position_touch_noise_filter.cc View 1 1 chunk +153 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/touch_noise_filter.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/touch_noise_finder.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/touch_noise_finder.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/touch_noise/touch_noise_finder_unittest.cc View 1 chunk +140 lines, -0 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
pkotwicz
spang@ PTAL
5 years, 9 months ago (2015-03-26 18:50:44 UTC) #2
pkotwicz
Patch set #1 has the CL as it landed in https://codereview.chromium.org/991533002/
5 years, 9 months ago (2015-03-26 18:51:19 UTC) #3
spang
lgtm
5 years, 9 months ago (2015-03-26 18:51:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030403002/20001
5 years, 9 months ago (2015-03-26 18:52:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1845)
5 years, 9 months ago (2015-03-26 19:16:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030403002/20001
5 years, 9 months ago (2015-03-26 21:34:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1905)
5 years, 9 months ago (2015-03-26 22:06:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030403002/40001
5 years, 9 months ago (2015-03-27 14:05:57 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-27 15:02:43 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:03:42 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7289d5923c8368faefc03ddb4322a20866b16df
Cr-Commit-Position: refs/heads/master@{#322579}

Powered by Google App Engine
This is Rietveld 408576698