Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1030383003: Enable depend on stamp by default for all GN based grit targets. (Closed)

Created:
5 years, 9 months ago by knn
Modified:
5 years, 9 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable depend on stamp by default for all GN based grit targets. This is a cleanup change that removes support for the depfile based on first grit output. BUG=466315 Committed: https://crrev.com/cc28e0dcbe1df4308cce6181ea8cb025ef0d3aeb Cr-Commit-Position: refs/heads/master@{#322584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -28 lines) Patch
M build/android/gyp/util/build_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +11 lines, -26 lines 0 comments Download
M components/policy/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
knn
On 2015/03/26 18:13:29, knn wrote: > mailto:knn@chromium.org changed reviewers: > + mailto:cjhopman@chromium.org PTAL.
5 years, 9 months ago (2015-03-26 18:48:37 UTC) #2
cjhopman
lgtm
5 years, 9 months ago (2015-03-26 20:47:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030383003/1
5 years, 9 months ago (2015-03-26 21:57:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52205)
5 years, 9 months ago (2015-03-26 22:05:32 UTC) #8
knn
Philipp, I need owners review for affected callsite. For context, this flag had to be ...
5 years, 9 months ago (2015-03-27 00:35:15 UTC) #10
pneubeck (no reviews)
lgtm components/policy/BUILD.gn
5 years, 9 months ago (2015-03-27 07:59:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030383003/1
5 years, 9 months ago (2015-03-27 15:48:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 15:49:17 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:50:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc28e0dcbe1df4308cce6181ea8cb025ef0d3aeb
Cr-Commit-Position: refs/heads/master@{#322584}

Powered by Google App Engine
This is Rietveld 408576698