Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1030373003: Fix regression in Mac AX live region support (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scroll_container_relative_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression in Mac AX live region support As part of a refactoring, the code to detect if a new live region was added was accidentally modified to trigger if a live region was changed in any way. It should only trigger on a brand-new live region. BUG=469276 Committed: https://crrev.com/6f67a46b2822001d53d9df18d2f60b4f318c76e9 Cr-Commit-Position: refs/heads/master@{#322434}

Patch Set 1 #

Patch Set 2 : Check for subtree created too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 9 months ago (2015-03-26 17:28:00 UTC) #2
David Tseng
lgtm
5 years, 9 months ago (2015-03-26 17:37:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030373003/20001
5 years, 9 months ago (2015-03-26 17:38:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 18:29:28 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 18:30:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f67a46b2822001d53d9df18d2f60b4f318c76e9
Cr-Commit-Position: refs/heads/master@{#322434}

Powered by Google App Engine
This is Rietveld 408576698