Replace a CHECK in the socket pool code with a NOTREACHED().

Replace a CHECK in the socket pool code with a NOTREACHED().

The CHECK is being triggered for unknown reasons, which may or may
not be due to a bug.  The NOTREACHED restores the old behavior, which
was changed in https://codereview.chromium.org/966943005/.

BUG=470656
Committed: https://crrev.com/8b1beebfbb2d05057a142cd15af331895559cad1
Cr-Commit-Position: refs/heads/master@{#322641}

[mmenke, 2015-03-26 16:30:20]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2015-03-26 16:30:21]

Good call on the CHECK.  It is being hit.

I spent a little time digging through crash dumps, and it seems to be SSL
related, but I couldn't repro locally, even after making RDH update load states
more aggressive.  Tried with self-signed certs and auth.  Didn't try with client
auth.

Open to suggestions, but decided it was low enough priority that without evident
of some sort of user-visible bug, it wasn't worth further investigation for the
moment.

[mmenke, 2015-03-27 19:05:45]

eroman:  Ping!  No real rush on this, but it's pretty trivial.

[eroman, 2015-03-27 19:51:02]

lgtm

https://codereview.chromium.org/1030373002/diff/1/net/socket/client_socket_po...
File net/socket/client_socket_pool_base.cc (right):

https://codereview.chromium.org/1030373002/diff/1/net/socket/client_socket_po...
net/socket/client_socket_pool_base.cc:567: // TODO(mmenke):  This is actually
reachec in the wild, for unknown reasons.
reached

[mmenke, 2015-03-27 19:59:27]

Thanks!

https://codereview.chromium.org/1030373002/diff/1/net/socket/client_socket_po...
File net/socket/client_socket_pool_base.cc (right):

https://codereview.chromium.org/1030373002/diff/1/net/socket/client_socket_po...
net/socket/client_socket_pool_base.cc:567: // TODO(mmenke):  This is actually
reachec in the wild, for unknown reasons.
On 2015/03/27 19:51:02, eroman wrote:
> reached

Done.

[mmenke, 2015-03-27 19:59:31]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-03-27 19:59:31]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1030373002/#ps20001
(title: "Fix typo")

[commit-bot: I haz the power, 2015-03-27 19:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030373002/20001

[commit-bot: I haz the power, 2015-03-27 20:57:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-27 20:58:19]

Patchset 2 (id:??) landed as
https://crrev.com/8b1beebfbb2d05057a142cd15af331895559cad1
Cr-Commit-Position: refs/heads/master@{#322641}