Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1030353004: small fix for nanobench segfault when not running any tests (Closed)

Created:
5 years, 9 months ago by joshua.litt
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

small fix for nanobench segfault when not running any tests BUG=skia: Committed: https://skia.googlesource.com/skia/+/e0b19d4985846d64bb581013828a9dc5af401a5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M bench/nanobench.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
5 years, 9 months ago (2015-03-26 17:06:17 UTC) #2
mtklein
lgtm
5 years, 9 months ago (2015-03-26 17:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030353004/1
5 years, 9 months ago (2015-03-26 17:17:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e0b19d4985846d64bb581013828a9dc5af401a5d
5 years, 9 months ago (2015-03-26 17:41:06 UTC) #6
tomhudson
5 years, 9 months ago (2015-03-26 17:57:42 UTC) #8
Message was sent while issue was closed.
Possibly fixes https://code.google.com/p/skia/issues/detail?id=3573?

Powered by Google App Engine
This is Rietveld 408576698