src/x64/assembler-x64.cc - Issue 1030353003: Enable constant pool support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 1030353003: Enable constant pool support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index abdf7a5d9c9fac54006a24e2cec39efc4e7d55b5..a33193874a4b9a0ada8b6ee4094b278d17c568c2 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -3503,14 +3503,14 @@ void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {

Handle<ConstantPoolArray> Assembler::NewConstantPool(Isolate* isolate) {

// No out-of-line constant pool support.

- DCHECK(!FLAG_enable_ool_constant_pool);

+ UNREACHABLE();

return isolate->factory()->empty_constant_pool_array();

}

void Assembler::PopulateConstantPool(ConstantPoolArray* constant_pool) {

// No out-of-line constant pool support.

- DCHECK(!FLAG_enable_ool_constant_pool);

+ UNREACHABLE();

return;

}