Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: src/macro-assembler.h

Issue 1030353003: Enable constant pool support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/macro-assembler.h
diff --git a/src/macro-assembler.h b/src/macro-assembler.h
index 166ac428b57767f82f452a2870f93c8c34fac0a2..95eccaba3541335699fa1539947a44b386e94dc3 100644
--- a/src/macro-assembler.h
+++ b/src/macro-assembler.h
@@ -137,11 +137,12 @@ class FrameAndConstantPoolScope {
: masm_(masm),
type_(type),
old_has_frame_(masm->has_frame()),
- old_constant_pool_available_(FLAG_enable_ool_constant_pool &&
- masm->is_ool_constant_pool_available()) {
+ old_constant_pool_available_((FLAG_enable_ool_constant_pool ||
+ FLAG_enable_embedded_constant_pool) &&
+ masm->is_constant_pool_available()) {
masm->set_has_frame(true);
- if (FLAG_enable_ool_constant_pool) {
- masm->set_ool_constant_pool_available(true);
+ if (FLAG_enable_ool_constant_pool || FLAG_enable_embedded_constant_pool) {
+ masm->set_constant_pool_available(true);
}
if (type_ != StackFrame::MANUAL && type_ != StackFrame::NONE) {
masm->EnterFrame(type, !old_constant_pool_available_);
@@ -151,8 +152,8 @@ class FrameAndConstantPoolScope {
~FrameAndConstantPoolScope() {
masm_->LeaveFrame(type_);
masm_->set_has_frame(old_has_frame_);
- if (FLAG_enable_ool_constant_pool) {
- masm_->set_ool_constant_pool_available(old_constant_pool_available_);
+ if (FLAG_enable_ool_constant_pool || FLAG_enable_embedded_constant_pool) {
+ masm_->set_constant_pool_available(old_constant_pool_available_);
}
}
@@ -180,15 +181,16 @@ class ConstantPoolUnavailableScope {
public:
explicit ConstantPoolUnavailableScope(MacroAssembler* masm)
: masm_(masm),
- old_constant_pool_available_(FLAG_enable_ool_constant_pool &&
- masm->is_ool_constant_pool_available()) {
- if (FLAG_enable_ool_constant_pool) {
- masm_->set_ool_constant_pool_available(false);
+ old_constant_pool_available_((FLAG_enable_ool_constant_pool ||
+ FLAG_enable_embedded_constant_pool) &&
+ masm->is_constant_pool_available()) {
+ if (FLAG_enable_ool_constant_pool || FLAG_enable_embedded_constant_pool) {
+ masm_->set_constant_pool_available(false);
}
}
~ConstantPoolUnavailableScope() {
- if (FLAG_enable_ool_constant_pool) {
- masm_->set_ool_constant_pool_available(old_constant_pool_available_);
+ if (FLAG_enable_ool_constant_pool || FLAG_enable_embedded_constant_pool) {
+ masm_->set_constant_pool_available(old_constant_pool_available_);
}
}

Powered by Google App Engine
This is Rietveld 408576698