content/renderer/accessibility/blink_ax_enum_conversion.cc - Issue 1030333002: Chromium side Implementation of new roles added in ARIA 1.1 draft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 1030333002: Chromium side Implementation of new roles added in ARIA 1.1 draft. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating failed expectations Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_browsertest.cc ('k') | content/shell/renderer/test_runner/web_ax_object_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_enum_conversion.cc

diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc

index 9fe5b24999cf77097fb5bc97cb64ed60fc29409e..3220aad022e8ea2092a7d29e5b6c1f981b768ad3 100644

--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc

+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc

@@ -264,6 +264,8 @@ ui::AXRole AXRoleFromBlink(blink::WebAXRole role) {

return ui::AX_ROLE_SEAMLESS_WEB_AREA;

case blink::WebAXRoleSearch:

return ui::AX_ROLE_SEARCH;

+ case blink::WebAXRoleSearchBox:

+ return ui::AX_ROLE_SEARCH_BOX;

case blink::WebAXRoleSlider:

return ui::AX_ROLE_SLIDER;

case blink::WebAXRoleSliderThumb:

@@ -278,6 +280,8 @@ ui::AXRole AXRoleFromBlink(blink::WebAXRole role) {

return ui::AX_ROLE_STATIC_TEXT;

case blink::WebAXRoleStatus:

return ui::AX_ROLE_STATUS;

+ case blink::WebAXRoleSwitch:

+ return ui::AX_ROLE_SWITCH;

case blink::WebAXRoleTab:

return ui::AX_ROLE_TAB;

case blink::WebAXRoleTabGroup: