Chromium side Implementation of new roles added in ARIA 1.1 draft.

Chromium side Implementation of new roles added in ARIA 1.1 draft.

Following roles has been mapped for win,mac & android platform.
1. switch role
2. searchbox role

Also some cleanups are done in this CL.

BUG=468667
Committed: https://crrev.com/b0ec609a1fc0f4512bb16d906ff4627e485955f8
Cr-Commit-Position: refs/heads/master@{#322544}

[shreeramk, 2015-03-27 03:38:51]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, nektar@chromium.org

[shreeramk, 2015-03-27 03:38:51]

PTAL. Thanks!!

[shreeramk, 2015-03-27 03:49:44]

shreeram.k@samsung.com changed reviewers:
+ avi@chromium.org

[shreeramk, 2015-03-27 03:49:45]

avi@chromium.org: Please review changes in content_strings.grd. Thanks!

[Avi (use Gerrit), 2015-03-27 04:08:35]

strings lgtm

[dmazzoni, 2015-03-27 05:12:05]

lgtm

Nicely done!

https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:4061: case
ui::AX_ROLE_SEARCH_BOX:
Maybe this should be a text field? I don't think it's typically multiline,
right?

https://codereview.chromium.org/1030333002/diff/40001/content/test/data/acces...
File content/test/data/accessibility/aria/aria-switch.html (right):

https://codereview.chromium.org/1030333002/diff/40001/content/test/data/acces...
content/test/data/accessibility/aria/aria-switch.html:9: <div role="switch">ARIA
role switch.</div>
Please add different variants of this with aria-checked, kind of like
aria-checkbox.html.

[shreeramk, 2015-03-27 05:19:05]

https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:4061: case
ui::AX_ROLE_SEARCH_BOX:
On 2015/03/27 05:12:05, dmazzoni wrote:
> Maybe this should be a text field? I don't think it's typically multiline,
> right?

But it does support aria-multiline. And superclass role is textbox which is
exposed as AX_ROLE_TEXT_AREA in AXObject.cpp

[dmazzoni, 2015-03-27 05:32:27]

https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:4061: case
ui::AX_ROLE_SEARCH_BOX:
On 2015/03/27 05:19:05, shreeramk wrote:
> On 2015/03/27 05:12:05, dmazzoni wrote:
> > Maybe this should be a text field? I don't think it's typically multiline,
> > right?
> 
> But it does support aria-multiline. And superclass role is textbox which is
> exposed as AX_ROLE_TEXT_AREA in AXObject.cpp

In AXNodeObject::determineAriaRoleAttribute, it gets changed to TextFieldRole if
aria-multiline is false.

I think we need to fix multiline support in general, and that's beyond this
changelist.

Right now you're always mapping a search box to MULTI_LINE, and I don't think
that makes sense. Map it to SINGLE_LINE for now, that's going to be correct 99%
of the time. I filed http://crbug.com/471152 to fix the multiline issue.

[shreeramk, 2015-03-27 05:38:43]

On 2015/03/27 05:32:27, dmazzoni wrote:
>
https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
> File content/browser/accessibility/browser_accessibility_win.cc (right):
> 
>
https://codereview.chromium.org/1030333002/diff/40001/content/browser/accessi...
> content/browser/accessibility/browser_accessibility_win.cc:4061: case
> ui::AX_ROLE_SEARCH_BOX:
> On 2015/03/27 05:19:05, shreeramk wrote:
> > On 2015/03/27 05:12:05, dmazzoni wrote:
> > > Maybe this should be a text field? I don't think it's typically multiline,
> > > right?
> > 
> > But it does support aria-multiline. And superclass role is textbox which is
> > exposed as AX_ROLE_TEXT_AREA in AXObject.cpp
> 
> In AXNodeObject::determineAriaRoleAttribute, it gets changed to TextFieldRole
if
> aria-multiline is false.
> 
> I think we need to fix multiline support in general, and that's beyond this
> changelist.
> 
> Right now you're always mapping a search box to MULTI_LINE, and I don't think
> that makes sense. Map it to SINGLE_LINE for now, that's going to be correct
99%
> of the time. I filed http://crbug.com/471152 to fix the multiline issue.


Ok. I ll map searchbox with text_field. And will fix multiline in a separate CL.

[shreeramk, 2015-03-27 09:06:25]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-03-27 09:06:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1030333002/#ps80001
(title: "Updating failed expectations")

[commit-bot: I haz the power, 2015-03-27 09:06:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1030333002/80001

[commit-bot: I haz the power, 2015-03-27 10:36:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-27 10:37:30]

Patchset 5 (id:??) landed as
https://crrev.com/b0ec609a1fc0f4512bb16d906ff4627e485955f8
Cr-Commit-Position: refs/heads/master@{#322544}