Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 103033004: commit remaining pdf-poppler GM results as unreviewed-by-humans (Closed)

Created:
7 years ago by epoger
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

commit remaining pdf-poppler GM results as unreviewed-by-humans BUG=skia:1884 TBR=vandebo Committed: https://code.google.com/p/skia/source/detail?r=12530

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -144 lines) Patch
expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 1 comment Download
expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 3 chunks +6 lines, -7 lines 0 comments Download
expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 4 chunks +20 lines, -9 lines 0 comments Download
expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 2 chunks +4 lines, -6 lines 1 comment Download
expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +2 lines, -4 lines 0 comments Download
expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 2 chunks +12 lines, -4 lines 0 comments Download
expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 2 chunks +12 lines, -4 lines 0 comments Download
expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 2 chunks +12 lines, -4 lines 0 comments Download
expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 4 chunks +20 lines, -9 lines 0 comments Download
expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 4 chunks +20 lines, -9 lines 0 comments Download
expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 2 chunks +12 lines, -4 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download
expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 3 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
https://codereview.chromium.org/103033004/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json File expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json (right): https://codereview.chromium.org/103033004/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json#newcode9620 expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json:9620: "bugs": [ Diff confirms that all of these are ...
7 years ago (2013-12-06 17:02:24 UTC) #1
epoger
Committed patchset #1 manually as r12530.
7 years ago (2013-12-06 17:03:33 UTC) #2
epoger
committed TBR
7 years ago (2013-12-06 17:03:58 UTC) #3
vandebo (ex-Chrome)
7 years ago (2013-12-09 20:52:18 UTC) #4
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698