Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1030323003: [Extensions] Don't inject scripts into remote frames, null documents. (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Don't inject scripts into remote frames, null documents. BUG=466520 Committed: https://crrev.com/d406f43ddf5e6b3ce75964d00689514e155ceaee Cr-Commit-Position: refs/heads/master@{#322651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M extensions/renderer/programmatic_script_injector.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
Nasko, mind taking a look?
5 years, 9 months ago (2015-03-27 18:54:05 UTC) #2
nasko
LGTM
5 years, 9 months ago (2015-03-27 20:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030323003/1
5 years, 9 months ago (2015-03-27 20:37:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 21:57:51 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 21:58:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d406f43ddf5e6b3ce75964d00689514e155ceaee
Cr-Commit-Position: refs/heads/master@{#322651}

Powered by Google App Engine
This is Rietveld 408576698