Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1030293002: increase default protocol version from 42 to 43 (Closed)

Created:
5 years, 9 months ago by Gang Wu
Modified:
5 years, 9 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Server side update the protocol version, because server side adding a error type, which is partial_faulure. we already support this error type, so this change just need to update default version. BUG=470736 Committed: https://crrev.com/5d75fb5a411a0f9cb18d893965c8e207f08a3918 Cr-Commit-Position: refs/heads/master@{#322329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sync/protocol/sync.proto View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Gang Wu
please take a look
5 years, 9 months ago (2015-03-26 00:29:33 UTC) #2
Nicolas Zea
Could you update the commit message to start with [Sync]? This helps us identify sync ...
5 years, 9 months ago (2015-03-26 01:31:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030293002/1
5 years, 9 months ago (2015-03-26 05:48:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 05:52:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 05:53:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d75fb5a411a0f9cb18d893965c8e207f08a3918
Cr-Commit-Position: refs/heads/master@{#322329}

Powered by Google App Engine
This is Rietveld 408576698